Remove remaining CRT PAL wrappers and enable including standard headers in the CoreCLR build #98336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jkotas
reviewed
Feb 13, 2024
jkotas
reviewed
Feb 13, 2024
jkoritzinsky
force-pushed
the
misc-pal
branch
from
5b3ac09
to
876a02d
Compare
Diff results for #98336Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Overall (+0.02% to +0.05%)
MinOpts (+0.00% to +0.02%)
FullOpts (+0.02% to +0.06%)
Throughput diffs for linux/x64 ran on windows/x64Overall (-0.00% to +0.04%)
MinOpts (-0.03% to +0.08%)
FullOpts (-0.00% to +0.04%)
Throughput diffs for osx/arm64 ran on windows/x64Overall (+0.02% to +0.05%)
MinOpts (+0.00% to +0.03%)
FullOpts (+0.02% to +0.06%)
Throughput diffs for windows/arm64 ran on windows/x64Overall (+0.02% to +0.05%)
MinOpts (+0.00% to +0.02%)
FullOpts (+0.02% to +0.06%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.00% to +0.04%)
MinOpts (-0.02% to +0.09%)
FullOpts (+0.00% to +0.04%)
Details here Throughput diffs for linux/arm ran on linux/x86Overall (+0.04% to +0.07%)
MinOpts (+0.05% to +0.09%)
FullOpts (+0.04% to +0.07%)
Throughput diffs for windows/x86 ran on linux/x86Overall (+0.05% to +0.08%)
MinOpts (+0.00% to +0.09%)
FullOpts (+0.06% to +0.09%)
Details here |
This was referenced Feb 13, 2024
Diff results for #98336Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Overall (+0.02% to +0.05%)
MinOpts (+0.00% to +0.03%)
FullOpts (+0.02% to +0.06%)
Throughput diffs for linux/x64 ran on windows/x64Overall (-0.00% to +0.04%)
MinOpts (-0.02% to +0.08%)
FullOpts (-0.00% to +0.04%)
Throughput diffs for osx/arm64 ran on windows/x64Overall (+0.02% to +0.05%)
MinOpts (+0.00% to +0.02%)
FullOpts (+0.02% to +0.06%)
Throughput diffs for windows/arm64 ran on windows/x64Overall (+0.02% to +0.05%)
MinOpts (+0.00% to +0.02%)
FullOpts (+0.02% to +0.06%)
Throughput diffs for windows/x64 ran on windows/x64Overall (+0.00% to +0.04%)
MinOpts (-0.02% to +0.08%)
FullOpts (-0.00% to +0.04%)
Details here Throughput diffs for linux/arm ran on windows/x86Overall (+0.04% to +0.07%)
MinOpts (+0.05% to +0.09%)
FullOpts (+0.04% to +0.07%)
Throughput diffs for windows/x86 ran on windows/x86Overall (+0.05% to +0.08%)
MinOpts (+0.00% to +0.09%)
FullOpts (+0.06% to +0.08%)
Details here |
Diff results for #98336Throughput diffsThroughput diffs for linux/arm ran on windows/x86Overall (+0.04% to +0.07%)
MinOpts (+0.05% to +0.09%)
FullOpts (+0.04% to +0.07%)
Throughput diffs for windows/x86 ran on windows/x86Overall (+0.05% to +0.08%)
MinOpts (+0.00% to +0.09%)
FullOpts (+0.06% to +0.08%)
Details here |
…AL features that would need global cleanup before process exit.
…d in a zero size to bump it to 1 manually on all platforms.
…ere using it through the define.
…ing impl and maintain PAL logging
…ning on GCC that catches more cases than Clang, at least for now
jkoritzinsky
force-pushed
the
misc-pal
branch
from
4079ebd
to
16a04e0
Compare
jkoritzinsky
requested review from
thaystg,
lambdageek and
MichalStrehovsky
as code owners
|
@janvorli any more feedback on this PR? |
|
I'm taking a last look now. |
janvorli
approved these changes
Apr 3, 2024
src/coreclr/debug/inc/dbgipcevents.h
Outdated
| @@ -768,7 +768,7 @@ class MSLAYOUT VMPTR_Base | |||
| // | |||
| // Operators to emulate Pointer semantics. | |||
| // | |||
| bool IsNull() { SUPPORTS_DAC; return m_addr == NULL; } | |||
| bool IsNull() { SUPPORTS_DAC; return m_addr == (TADDR)NULL; } | |||
There was a problem hiding this comment.
@jkoritzinsky can you please change this the way @jkotas suggested?
AaronRobinsonMSFT
approved these changes
Apr 3, 2024
|
/ba-g Timeouts look like the slow mac issue, all with non-CoreCLR runtimes. |
|
Amazing. I never thought this would happen. Could (should) someone convert the JIT from the jitstd implementations of Is there guidance about what parts of the STL can and can't be used? |
Not at present, but we need to avoid cases where exceptions are thrown. This means no STL collections should be used in the product. Using in tests is fine, but we need to make sure the code isn't shared in some non-obvious manner. If someone wanted to use the STL collections the first step would be to write a custom allocator so we can control the failure mode. Ideally we would typedef all the STL collections to be something like My preference, no way to enforce this, would be for me and a group of others to be added to PRs where new uses of the STL are used. After a while we will all agree on approved patterns and then we can document them appropriately. |
|
I'll work on a doc for guidance for STL usage with some useful typedefs. |
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 8, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<=13. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 8, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 8, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 8, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 9, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 9, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
shushanhf
added a commit
to shushanhf/runtime
that referenced
this pull request
Apr 9, 2024
…code` when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…rs in the CoreCLR build (dotnet#98336) - Remove malloc-family PAL and update callsites that might get passed 0 to bump up to 1. - Move `getenv` usage to use the `PAL` function directly when on non-Windows (to preserve the existing behavior). - Remove other remaining CRT PAL shims - Remove header shims and enable building with the CRT and STL headers across the product, with various build fixes required (mostly around using the standard min/max definitions)
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…code` (dotnet#100742) when building on debug mode on loongarch64/arm64/amd64-linux by clang<14. Also delete `#ifndef FALLTHROUGH` block as dotnet#98336 added after dotnet#98712.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #98238getenvusage to use thePALfunction directly when on non-Windows (to preserve the existing behavior).