Disable vector ctors intrinsics on wasm #98114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This will fail on amd64 as well, only arm64 enables Vector3 rn. I'd suggest the check from |
|
This code is not reachable on amd64 runtime/src/mono/mono/mini/simd-intrinsics.c Lines 2697 to 2700 in 0fafa50 |
vargaz
approved these changes
Feb 7, 2024
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 7, 2024
|
This is still happening on the fullaot llvm x64 lanes: |
|
We do have llvm support for vector2 and vector3. It could be a matter of enabling it as simd on llvm amd64. Will look into that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix WASM regression: https://dev.azure.com/dnceng-public/public/_build/results?buildId=556904&view=logs&jobId=b455efc5-4fe2-50ab-5106-412ad73c23a0&j=b455efc5-4fe2-50ab-5106-412ad73c23a0&t=607d8ddd-2371-58ff-95a3-14f9242e8c35
Caused by: #98037
Vector2 and Vector3 are not marked as SIMD on WASM.