Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main build #98011

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fix main build #98011

merged 1 commit into from
Feb 6, 2024

Conversation

MichalPetryka
Copy link
Contributor

@MichalPetryka MichalPetryka commented Feb 6, 2024

Fixes #98009.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 6, 2024
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 6, 2024
@ghost
Copy link

ghost commented Feb 6, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Feb 6, 2024

I verified locally that it fixes the build, let's not wait for a full CI cycle and merge it to unblock

@EgorBo EgorBo merged commit 77e91e6 into dotnet:main Feb 6, 2024
13 of 95 checks passed
@ryujit-bot
Copy link

Diff results for #98011

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Overall (-0.62% to -0.26%)
Collection PDIFF
benchmarks.run.linux.arm64.checked.mch -0.27%
benchmarks.run_pgo.linux.arm64.checked.mch -0.34%
benchmarks.run_tiered.linux.arm64.checked.mch -0.62%
coreclr_tests.run.linux.arm64.checked.mch -0.47%
libraries.crossgen2.linux.arm64.checked.mch -0.43%
libraries.pmi.linux.arm64.checked.mch -0.29%
libraries_tests.run.linux.arm64.Release.mch -0.51%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.30%
realworld.run.linux.arm64.checked.mch -0.27%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.26%
MinOpts (-1.28% to -0.76%)
Collection PDIFF
benchmarks.run.linux.arm64.checked.mch -1.01%
benchmarks.run_pgo.linux.arm64.checked.mch -1.03%
benchmarks.run_tiered.linux.arm64.checked.mch -1.04%
coreclr_tests.run.linux.arm64.checked.mch -0.94%
libraries.crossgen2.linux.arm64.checked.mch -1.05%
libraries.pmi.linux.arm64.checked.mch -0.76%
libraries_tests.run.linux.arm64.Release.mch -1.06%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -1.01%
realworld.run.linux.arm64.checked.mch -1.28%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.88%
FullOpts (-0.43% to -0.25%)
Collection PDIFF
benchmarks.run.linux.arm64.checked.mch -0.27%
benchmarks.run_pgo.linux.arm64.checked.mch -0.25%
benchmarks.run_tiered.linux.arm64.checked.mch -0.25%
coreclr_tests.run.linux.arm64.checked.mch -0.29%
libraries.crossgen2.linux.arm64.checked.mch -0.43%
libraries.pmi.linux.arm64.checked.mch -0.29%
libraries_tests.run.linux.arm64.Release.mch -0.26%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.28%
realworld.run.linux.arm64.checked.mch -0.27%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.26%

Throughput diffs for osx/arm64 ran on windows/x64

Overall (-0.71% to -0.27%)
Collection PDIFF
benchmarks.run.osx.arm64.checked.mch -0.27%
benchmarks.run_pgo.osx.arm64.checked.mch -0.49%
benchmarks.run_tiered.osx.arm64.checked.mch -0.59%
coreclr_tests.run.osx.arm64.checked.mch -0.54%
libraries.crossgen2.osx.arm64.checked.mch -0.43%
libraries.pmi.osx.arm64.checked.mch -0.29%
libraries_tests.run.osx.arm64.Release.mch -0.71%
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch -0.30%
realworld.run.osx.arm64.checked.mch -0.27%
MinOpts (-1.29% to -0.76%)
Collection PDIFF
benchmarks.run.osx.arm64.checked.mch -1.14%
benchmarks.run_pgo.osx.arm64.checked.mch -1.05%
benchmarks.run_tiered.osx.arm64.checked.mch -1.07%
coreclr_tests.run.osx.arm64.checked.mch -0.99%
libraries.crossgen2.osx.arm64.checked.mch -1.04%
libraries.pmi.osx.arm64.checked.mch -0.76%
libraries_tests.run.osx.arm64.Release.mch -1.07%
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch -1.02%
realworld.run.osx.arm64.checked.mch -1.29%
FullOpts (-0.43% to -0.23%)
Collection PDIFF
benchmarks.run.osx.arm64.checked.mch -0.27%
benchmarks.run_pgo.osx.arm64.checked.mch -0.23%
benchmarks.run_tiered.osx.arm64.checked.mch -0.25%
coreclr_tests.run.osx.arm64.checked.mch -0.29%
libraries.crossgen2.osx.arm64.checked.mch -0.43%
libraries.pmi.osx.arm64.checked.mch -0.29%
libraries_tests.run.osx.arm64.Release.mch -0.26%
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch -0.28%
realworld.run.osx.arm64.checked.mch -0.27%

Throughput diffs for windows/arm64 ran on windows/x64

Overall (-0.58% to -0.26%)
Collection PDIFF
benchmarks.run.windows.arm64.checked.mch -0.27%
benchmarks.run_pgo.windows.arm64.checked.mch -0.34%
benchmarks.run_tiered.windows.arm64.checked.mch -0.58%
coreclr_tests.run.windows.arm64.checked.mch -0.45%
libraries.crossgen2.windows.arm64.checked.mch -0.44%
libraries.pmi.windows.arm64.checked.mch -0.29%
libraries_tests.run.windows.arm64.Release.mch -0.33%
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch -0.30%
realworld.run.windows.arm64.checked.mch -0.27%
smoke_tests.nativeaot.windows.arm64.checked.mch -0.26%
MinOpts (-1.29% to -0.77%)
Collection PDIFF
benchmarks.run.windows.arm64.checked.mch -1.12%
benchmarks.run_pgo.windows.arm64.checked.mch -1.04%
benchmarks.run_tiered.windows.arm64.checked.mch -1.06%
coreclr_tests.run.windows.arm64.checked.mch -0.91%
libraries.crossgen2.windows.arm64.checked.mch -1.05%
libraries.pmi.windows.arm64.checked.mch -0.77%
libraries_tests.run.windows.arm64.Release.mch -1.03%
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch -1.02%
realworld.run.windows.arm64.checked.mch -1.29%
smoke_tests.nativeaot.windows.arm64.checked.mch -0.88%
FullOpts (-0.44% to -0.24%)
Collection PDIFF
benchmarks.run.windows.arm64.checked.mch -0.27%
benchmarks.run_pgo.windows.arm64.checked.mch -0.24%
benchmarks.run_tiered.windows.arm64.checked.mch -0.25%
coreclr_tests.run.windows.arm64.checked.mch -0.29%
libraries.crossgen2.windows.arm64.checked.mch -0.44%
libraries.pmi.windows.arm64.checked.mch -0.29%
libraries_tests.run.windows.arm64.Release.mch -0.28%
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch -0.28%
realworld.run.windows.arm64.checked.mch -0.27%
smoke_tests.nativeaot.windows.arm64.checked.mch -0.26%

Throughput diffs for windows/x64 ran on windows/x64

Overall (+0.00% to +0.01%)
Collection PDIFF
benchmarks.run_pgo.windows.x64.checked.mch +0.01%
FullOpts (+0.00% to +0.02%)
Collection PDIFF
benchmarks.run_pgo.windows.x64.checked.mch +0.02%

Details here


Throughput diffs for linux/arm64 ran on linux/x64

Overall (-0.02% to -0.00%)
Collection PDIFF
libraries_tests.run.linux.arm64.Release.mch -0.01%
benchmarks.run_pgo.linux.arm64.checked.mch -0.01%
libraries.pmi.linux.arm64.checked.mch -0.01%
benchmarks.run_tiered.linux.arm64.checked.mch -0.02%
libraries.crossgen2.linux.arm64.checked.mch -0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.01%
coreclr_tests.run.linux.arm64.checked.mch -0.02%
benchmarks.run.linux.arm64.checked.mch -0.01%
MinOpts (-0.08% to -0.01%)
Collection PDIFF
libraries_tests.run.linux.arm64.Release.mch -0.03%
realworld.run.linux.arm64.checked.mch -0.08%
benchmarks.run_pgo.linux.arm64.checked.mch -0.03%
libraries.pmi.linux.arm64.checked.mch -0.02%
benchmarks.run_tiered.linux.arm64.checked.mch -0.03%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.01%
libraries.crossgen2.linux.arm64.checked.mch -0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.03%
coreclr_tests.run.linux.arm64.checked.mch -0.03%
benchmarks.run.linux.arm64.checked.mch -0.02%
FullOpts (-0.01% to -0.00%)
Collection PDIFF
libraries_tests.run.linux.arm64.Release.mch -0.01%
benchmarks.run_pgo.linux.arm64.checked.mch -0.01%
libraries.pmi.linux.arm64.checked.mch -0.01%
benchmarks.run_tiered.linux.arm64.checked.mch -0.01%
libraries.crossgen2.linux.arm64.checked.mch -0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.01%
coreclr_tests.run.linux.arm64.checked.mch -0.01%
benchmarks.run.linux.arm64.checked.mch -0.01%

Details here


@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure in RyuJIT for ARM64
5 participants