Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT ARM64-SVE: Implement IF_SVE_EG_3A, IF_SVE_EY_3A, IF_SVE_EZ_3A #97900

Merged
merged 6 commits into from
Feb 3, 2024

Conversation

amanasifkhalid
Copy link
Member

Part of #94549.

cstool output:

sdot  z1.s, z2.h, z0.h[0]
sdot  z3.s, z4.h, z1.h[1]
udot  z5.s, z6.h, z2.h[2]
udot  z7.s, z8.h, z3.h[3]
sdot  z9.s, z10.b, z4.b[0]
sdot  z11.s, z12.b, z5.b[1]
udot  z13.s, z14.b, z6.b[2]
udot  z15.s, z16.b, z7.b[3]
sudot z17.s, z18.b, z0.b[0]
sudot z19.s, z20.b, z1.b[1]
usdot z21.s, z22.b, z2.b[2]
usdot z23.s, z24.b, z3.b[3]

JitDisasm output:

sdot    z1.s, z2.h, z0.h[0]
sdot    z3.s, z4.h, z1.h[1]
udot    z5.s, z6.h, z2.h[2]
udot    z7.s, z8.h, z3.h[3]
sdot    z9.s, z10.b, z4.b[0]
sdot    z11.s, z12.b, z5.b[1]
udot    z13.s, z14.b, z6.b[2]
udot    z15.s, z16.b, z7.b[3]
sudot   z17.s, z18.b, z0.b[0]
sudot   z19.s, z20.b, z1.b[1]
usdot   z21.s, z22.b, z2.b[2]
usdot   z23.s, z24.b, z3.b[3]

cc @dotnet/arm64-contrib.

@amanasifkhalid amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support labels Feb 2, 2024
@ghost
Copy link

ghost commented Feb 2, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #94549.

cstool output:

sdot  z1.s, z2.h, z0.h[0]
sdot  z3.s, z4.h, z1.h[1]
udot  z5.s, z6.h, z2.h[2]
udot  z7.s, z8.h, z3.h[3]
sdot  z9.s, z10.b, z4.b[0]
sdot  z11.s, z12.b, z5.b[1]
udot  z13.s, z14.b, z6.b[2]
udot  z15.s, z16.b, z7.b[3]
sudot z17.s, z18.b, z0.b[0]
sudot z19.s, z20.b, z1.b[1]
usdot z21.s, z22.b, z2.b[2]
usdot z23.s, z24.b, z3.b[3]

JitDisasm output:

sdot    z1.s, z2.h, z0.h[0]
sdot    z3.s, z4.h, z1.h[1]
udot    z5.s, z6.h, z2.h[2]
udot    z7.s, z8.h, z3.h[3]
sdot    z9.s, z10.b, z4.b[0]
sdot    z11.s, z12.b, z5.b[1]
udot    z13.s, z14.b, z6.b[2]
udot    z15.s, z16.b, z7.b[3]
sudot   z17.s, z18.b, z0.b[0]
sudot   z19.s, z20.b, z1.b[1]
usdot   z21.s, z22.b, z2.b[2]
usdot   z23.s, z24.b, z3.b[3]

cc @dotnet/arm64-contrib.

Author: amanasifkhalid
Assignees: -
Labels:

area-CodeGen-coreclr, arch-arm64-sve

Milestone: -

@ghost ghost assigned amanasifkhalid Feb 2, 2024
@ryujit-bot
Copy link

Diff results for #97900

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch +0.01%

Details here


@ryujit-bot
Copy link

Diff results for #97900

Throughput diffs

Throughput diffs for linux/arm64 ran on linux/x64

Overall (+0.00% to +0.01%)
Collection PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch +0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.01%
libraries_tests.run.linux.arm64.Release.mch +0.01%
coreclr_tests.run.linux.arm64.checked.mch +0.01%
benchmarks.run_tiered.linux.arm64.checked.mch +0.01%
MinOpts (+0.00% to +0.04%)
Collection PDIFF
benchmarks.run_pgo.linux.arm64.checked.mch +0.02%
realworld.run.linux.arm64.checked.mch +0.04%
libraries.pmi.linux.arm64.checked.mch +0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.02%
benchmarks.run.linux.arm64.checked.mch +0.02%
libraries.crossgen2.linux.arm64.checked.mch +0.01%
libraries_tests.run.linux.arm64.Release.mch +0.02%
coreclr_tests.run.linux.arm64.checked.mch +0.02%
benchmarks.run_tiered.linux.arm64.checked.mch +0.02%
FullOpts (+0.00% to +0.01%)
Collection PDIFF
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.01%
coreclr_tests.run.linux.arm64.checked.mch +0.01%

Details here


Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit 1c4428d into dotnet:main Feb 3, 2024
126 of 129 checks passed
@amanasifkhalid amanasifkhalid deleted the sve-sdot branch February 3, 2024 23:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants