Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify formatting part of BigInteger of CoreLib #97889

Merged
merged 14 commits into from
Mar 22, 2024
Merged

Unify formatting part of BigInteger of CoreLib #97889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ccddccb
Revert "Remove Formatting.Common for PR"
huoyaoyuan May 9, 2023
d208258
Move NumberToString and dependencies to Common
huoyaoyuan May 9, 2023
366dcae
NumberToStringFormat and ParseFormatSpecifier
huoyaoyuan Dec 5, 2023
77a321d
Polyfill for CoreLib internal members
huoyaoyuan Dec 5, 2023
fefc976
Use common formatting for BigInteger
huoyaoyuan Dec 5, 2023
7a34f0d
Remove unused FormatProvider and comments
huoyaoyuan May 11, 2023
e328288
Move CharStackBufferSize to CoreLib for now
huoyaoyuan Feb 3, 2024
563dd5d
Ue AOOE.ThrowIf method
huoyaoyuan Feb 3, 2024
643fcfe
Convert typeof assert to sizeof
huoyaoyuan Feb 18, 2024
ad201eb
Fix buffer length and type of span
huoyaoyuan Feb 18, 2024
789e2c1
Fix exponent length
huoyaoyuan Feb 18, 2024
c85aef2
Move unused DecimalPrecision back to CoreLib
huoyaoyuan Feb 18, 2024
643f9dc
Merge branch 'main'
huoyaoyuan Mar 18, 2024
feb2b9e
Port conflicting diffs
huoyaoyuan Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,191 changes: 1,191 additions & 0 deletions src/libraries/Common/src/System/Number.Formatting.Common.cs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,6 +1430,9 @@
<Compile Include="$(CommonPath)System\NotImplemented.cs">
<Link>Common\System\NotImplemented.cs</Link>
</Compile>
<Compile Include="$(CommonPath)System\Number.Formatting.Common.cs">
<Link>System\Number.Formatting.Common.cs</Link>
</Compile>
<Compile Include="$(CommonPath)System\Number.NumberBuffer.cs">
<Link>System\Number.NumberBuffer.cs</Link>
</Compile>
Expand Down
Loading
Loading