[mono][interp] Small code refactoring for SSA #97249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use interp_ prefix for non-static methods within interpreter (mono_interp seems rather long) Use interp_ prefix, instead of .._interp_..., for consistency. Use ins everywhere in method names for consistency, instead of inst.
In order to facilitate overwritting of sregs/dreg during instruction iterations. Also enable iterating only on sregs.
Local can have multiple meanings. Use it to refer to IL locals from now. All IL locals are vars. Vars can be local (single bblock use) or global.
Makes the code clearer and it is easier to maintain.
BrzVlad
requested review from
kg,
vargaz,
kotlarmilos,
lambdageek and
SamMonoRT
as code owners
ghost
assigned 
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsMainly moving optimization code out from transform.c which is getting massive.
|
vargaz
approved these changes
Jan 20, 2024
|
Failures are unrelated. |
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* [mono][interp] Move optimization related code out of transform.c Use interp_ prefix for non-static methods within interpreter (mono_interp seems rather long) Use interp_ prefix, instead of .._interp_..., for consistency. Use ins everywhere in method names for consistency, instead of inst. * [mono][interp] Pass ref to var storage in interp inst In order to facilitate overwritting of sregs/dreg during instruction iterations. Also enable iterating only on sregs. * [mono][interp] Print invalid il offset in aligned fashion * [mono][interp] Remove irrelevant stats * [mono][interp] Renaming of local to var Local can have multiple meanings. Use it to refer to IL locals from now. All IL locals are vars. Vars can be local (single bblock use) or global. * [mono][interp] Remove flags and use bit fields instead Makes the code clearer and it is easier to maintain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly moving optimization code out from transform.c which is getting massive.