Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frozen objects should be identified as Gen2 in the handle table #97109

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Frozen objects should be identified as Gen2 in the handle table #97109

merged 3 commits into from
Jan 20, 2024

Conversation

cshung
Copy link
Member

@cshung cshung commented Jan 17, 2024 •
edited by AaronRobinsonMSFT
Loading

Fixes #85234

@cshung cshung self-assigned this Jan 17, 2024
@ghost
Copy link

ghost commented Jan 17, 2024

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr
Milestone: -

@jkotas
Copy link
Member

jkotas commented Jan 17, 2024

Does HndWriteBarrierWorker need the same change? `

Is there going to be perf impact from this change? Would it be better to allow the clump generation to be truncted int32 maxvalue?

@build-analysis build-analysis bot mentioned this pull request Jan 17, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Jan 18, 2024
Open
@AaronRobinsonMSFT
Copy link
Member

I have verified locally that this fixes #85234

@jkotas jkotas requested a review from Maoni0 January 18, 2024 18:04
Maoni0
Maoni0 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a trivial comment I had when doing CR with Andrew which was to change the WhichGeneration to a more descriptive name so someone who reads the code doesn't always have to come to the header file to read that comment.

This was referenced Jan 20, 2024
Closed
Closed
@cshung cshung merged commit db3b80f into dotnet:main Jan 20, 2024
107 of 111 checks passed
@cshung cshung deleted the public/frozen-handles branch January 20, 2024 23:25
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Jan 23, 2024
Closed
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@cshung @tmds
Frozen objects should be identified as Gen2 in the handle table (dotn…
acea06f 
…et#97109)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@jkotas jkotas jkotas left review comments

@Maoni0 Maoni0 Maoni0 approved these changes

Assignees

@cshung cshung

Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure Interop\\MarshalAPI\\IUnknown\\IUnknownTest\\IUnknownTest.cmd
4 participants
@cshung @jkotas @AaronRobinsonMSFT @Maoni0