Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit PNSE by using Invariant HashCode in HybridGlobalization #96354

Merged
merged 24 commits into from
Jan 19, 2024
Merged

Limit PNSE by using Invariant HashCode in HybridGlobalization #96354

merged 24 commits into from
Jan 19, 2024

Commits on Dec 29, 2023

  1. Unblock all tests.

    @ilonatommy
    ilonatommy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    7f5d711 View commit details
    Browse the repository at this point in the history

  2. SortKey is Invariant now.

    @ilonatommy
    ilonatommy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    709da38 View commit details
    Browse the repository at this point in the history

  3. Missing SortKey changes + fix HashCode.

    @ilonatommy
    ilonatommy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6e72858 View commit details
    Browse the repository at this point in the history

  4. Typo

    @ilonatommy
    ilonatommy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    2d7a037 View commit details
    Browse the repository at this point in the history

  5. Revert unbocking tests connected with CompareOptions PNSE.

    @ilonatommy
    ilonatommy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b896c17 View commit details
    Browse the repository at this point in the history

  6. Hashing uses Invariant mode -these tests should be skipped.

    @ilonatommy
    ilonatommy committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    de22e70 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Add active issue.

    @ilonatommy
    ilonatommy committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5778cd0 View commit details
    Browse the repository at this point in the history

  2. feedback

    @ilonatommy
    ilonatommy committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    d0666cd View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Feedback

    @ilonatommy
    ilonatommy committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    65236ab View commit details
    Browse the repository at this point in the history

  2. Better documentation.

    @ilonatommy
    ilonatommy committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    0721f45 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'main' into fix-95921

    @ilonatommy
    ilonatommy authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    75586a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Add new tests + sanitize string before invariant comparison.

    @ilonatommy
    ilonatommy committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5625741 View commit details
    Browse the repository at this point in the history

  2. Comment + more cases.

    @ilonatommy
    ilonatommy committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    90024bd View commit details
    Browse the repository at this point in the history

  3. Clean CI.

    @ilonatommy
    ilonatommy committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    7acf408 View commit details
    Browse the repository at this point in the history

  4. Missing change for clean CI commit.

    @ilonatommy
    ilonatommy committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    89c55ad View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. SortKey not supported for non-invariant cultures, HashCode suppor… 

    …ted for non-invariant cultures only with `IgnoreCase` or `None` options.
    @ilonatommy
    ilonatommy committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    9423bcc View commit details
    Browse the repository at this point in the history

  2. Feedback.

    @ilonatommy
    ilonatommy committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2887914 View commit details
    Browse the repository at this point in the history

  3. Fix build, add docs.

    @ilonatommy
    ilonatommy committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a599f77 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Feedback @matouskozak @pavelsavara

    @ilonatommy
    ilonatommy committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c9dc938 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-95921

    @ilonatommy
    ilonatommy committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    bfb12b3 View commit details
    Browse the repository at this point in the history

  3. Added tests + fixed algo.

    @ilonatommy
    ilonatommy committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    398d047 View commit details
    Browse the repository at this point in the history

  4. Block failing tests for a follow-up PR.

    @ilonatommy
    ilonatommy committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ee1f542 View commit details
    Browse the repository at this point in the history

  5. Add more details to PNSE.

    @ilonatommy
    ilonatommy committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    10e9060 View commit details
    Browse the repository at this point in the history

  6. Feedback - correct comment

    @ilonatommy
    ilonatommy committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    80d9d37 View commit details
    Browse the repository at this point in the history