-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arm64 encodings for SVE IF_SVE_CX_4A_A to IF_SVE_HT_4A group #96214
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3ef3af4
Add SVE IF_SVE_CQ_4A_A group
SwapnilGaikwad ccbfdb8
Fix format issues
SwapnilGaikwad 0548526
Add Arm64 encodings for IF_SVE_GE_4A group
SwapnilGaikwad 4662492
Fix build issue
SwapnilGaikwad a93f47e
Merge branch 'main' into github-sve-cx_4a_a
SwapnilGaikwad 1756c12
Add Arm64 encodings for case IF_SVE_HT_4A group
SwapnilGaikwad 399133e
Merge main
SwapnilGaikwad a3827cd
Fix build and formatting
SwapnilGaikwad b427187
Remove redundant asserts
SwapnilGaikwad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While passing
INS_OPTS_SCALABLE_D
looks fine for this instruction format, I was checking other formats where we directly pass the INS_OPTS and seems like forIF_SVE_EQ_3A
, we should have a method that is reverse ofoptWidenSveElemsizeArrangement()
, which will basically lowerH->B
,S->H
andD->S
instead of manipulating theidOpts()
this way.runtime/src/coreclr/jit/emitarm64.cpp
Lines 18752 to 18755 in b498582
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, makes sense. I will piggyback this change on my next patch 👍