[infra] Enable trimming on Helix for Apple mobile #96169

kotlarmilos · 2023-12-19T10:22:33Z

Description

This PR (fixes #91923) introduces the trimming of library tests on Helix for Apple mobile targets. With trimming enabled, the configuration more closely mirrors the experience of an end user when building Apple mobile applications.

This change results in a 20min (42%) reduction in CI job builds for iOS (a subset of tests) and a 22min (18%) reduction for tvOS (the complete coverage)

Initial work is available at #92719.

Test job run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=622954&view=results

ghost · 2023-12-19T10:22:42Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This PR tests trimming on Helix for Apple mobile targets.

Initial work is available at #92719.

Author:	kotlarmilos
Assignees:	kotlarmilos
Labels:	`NO-MERGE`, `area-Infrastructure-mono`, `os-ios`
Milestone:	9.0.0

kotlarmilos · 2023-12-19T10:23:52Z

/azp run runtime-ioslike

azure-pipelines · 2023-12-19T10:24:02Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2023-12-19T11:29:13Z

/azp run runtime-ioslike

azure-pipelines · 2023-12-19T11:29:35Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2023-12-19T12:00:24Z

/azp run runtime-ioslike

azure-pipelines · 2023-12-19T12:00:37Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-03-27T13:00:56Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2024-03-28T21:06:04Z

/azp run runtime-ioslike

azure-pipelines · 2024-03-28T21:06:13Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2024-03-29T09:16:53Z

/azp run runtime-ioslikesimulator

azure-pipelines · 2024-03-29T09:17:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mdh1418 · 2024-04-02T18:01:55Z

eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml

-            testBuildArgs: /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=true /p:MonoForceInterpreter=true /p:BuildTestsOnHelix=true
-            testRunNamePrefixSuffix: Mono_$(_BuildConfig)
-            extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true
+      extraStepsTemplate: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml


We moved from extraStepsTemplate/extraStepsParameters in #92375, is there a particular reason as to why we are moving back?

Thanks, reverted. I assume this was a merge conflict issue.

mdh1418 · 2024-04-02T18:18:23Z

eng/testing/tests.ioslike.targets

@@ -16,7 +16,7 @@
    <!-- running aot-helix tests locally, so we can test with the same project file as CI -->
    <_AOTBuildCommand Condition="'$(ContinuousIntegrationBuild)' != 'true'">$(_AOTBuildCommand) /p:RuntimeSrcDir=$(RepoRoot) /p:RuntimeConfig=$(Configuration)</_AOTBuildCommand>
    <!-- The command below sets default properties for runtime and library tests -->
-    <_AOTBuildCommand>$(_AOTBuildCommand) /p:XHARNESS_EXECUTION_DIR=&quot;$XHARNESS_EXECUTION_DIR&quot; /p:RunAOTCompilation=$(RunAOTCompilation) /p:UseNativeAOTRuntime=$(UseNativeAOTRuntime) /p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:MonoForceInterpreter=$(MonoForceInterpreter) /p:MonoEnableLLVM=true /p:DevTeamProvisioning=$(DevTeamProvisioning) /p:UsePortableRuntimePack=true /p:Configuration=$(Configuration)</_AOTBuildCommand>
+    <_AOTBuildCommand>$(_AOTBuildCommand) /p:XHARNESS_EXECUTION_DIR=&quot;$XHARNESS_EXECUTION_DIR&quot; /p:EnableAggressiveTrimming=$(EnableAggressiveTrimming) /p:UsePortableRuntimePack=$(UsePortableRuntimePack) /p:RunAOTCompilation=$(RunAOTCompilation) /p:UseNativeAOTRuntime=$(UseNativeAOTRuntime) /p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:MonoForceInterpreter=$(MonoForceInterpreter) /p:MonoEnableLLVM=true /p:DevTeamProvisioning=$(DevTeamProvisioning) /p:Configuration=$(Configuration)</_AOTBuildCommand>


Which scenarios would we not want to use the portable runtime pack?

We can revert this change. We were testing different options for trimming on helix and one of them was to trim on build machines.

mdh1418 · 2024-04-02T18:31:50Z

src/mono/msbuild/apple/data/ProxyProjectForAOTOnHelix.proj

+    <OriginalPublishDir>$([System.IO.Path]::GetFullPath('$(TestRootDir)..\publish\'))</OriginalPublishDir>
+    <ExtraFilesPath>$(OriginalPublishDir)..\extraFiles\</ExtraFilesPath>


These are overwriting L6/L7

mdh1418 · 2024-04-02T18:48:16Z

src/mono/msbuild/apple/data/ProxyProjectForAOTOnHelix.proj

    <Copy SourceFiles="@(_RuntimePackFiles)"
          DestinationFolder="$(OriginalPublishDir)" />
  </Target>

+  <Target Name="_TrimApp" DependsOnTargets="ILLink;CopyFilesToPublishDirectory">
+    <Delete Files="@(_RemovedManagedAssembly)" />


Should we be deleting these files?

Is the main intent to prevent them from being added to AppleAssembliesToBundle?

Right, let's try to use _RemovedManagedAssembly to filter out AppleAssembliesToBundle.

mdh1418 · 2024-04-02T18:49:03Z

src/mono/msbuild/apple/data/ProxyProjectForAOTOnHelix.proj

+      <ReferencePath Include="@(AppleReferenceSharedPathFiles->'$(MicrosoftNetCoreAppRuntimePackLibDir)%(FileName)%(Extension)')" />
+      <ReferencePath Include="@(AppleReferenceExtraPathFiles->'$(ExtraFilesPath)%(FileName)%(Extension)')" />


What do these do?

The ReferencePath items are used by ILLink targets.

mdh1418 · 2024-04-02T18:54:52Z

src/mono/msbuild/apple/data/ProxyProjectForAOTOnHelix.proj

+    <AppleBuildDependsOn Condition="'$(EnableAggressiveTrimming)' == 'true' and '$(UseNativeAOTRuntime)' != 'true'">ConfigureTrimming;_TrimApp;$(AppleBuildDependsOn)</AppleBuildDependsOn>
+    <AppleBuildDependsOn>_PublishRuntimePack;_PrepareForAppleBuildAppOnHelix;$(AppleBuildDependsOn);_AfterAppleBuildOnHelix</AppleBuildDependsOn>
+    <!-- Forced by ILLink targets -->
+    <SelfContained>true</SelfContained>


Are we always hitting ILLink targets now (if so, we can probably remove L29 which also sets SelfContained to true right?)? Or is this now required because of ConfigureTrimming being added (if so we should only set this for the same conditions that ConfigureTrimming has right?)

Yes, I believe we can remove it.

mdh1418 · 2024-04-02T18:55:12Z

src/mono/msbuild/apple/data/ProxyProjectForAOTOnHelix.proj

+    <AppleBuildDependsOn>_PublishRuntimePack;_PrepareForAppleBuildAppOnHelix;$(AppleBuildDependsOn);_AfterAppleBuildOnHelix</AppleBuildDependsOn>
+    <!-- Forced by ILLink targets -->
+    <SelfContained>true</SelfContained>
+    <PublishDir>$(OriginalPublishDir)</PublishDir>


Is this also forced by ILLink targets? Or is there another reason to have this?

I think it is used by ILLink targets.

mdh1418 · 2024-04-02T19:01:54Z

src/mono/msbuild/apple/data/ProxyProjectForAOTOnHelix.proj


  <Target Name="BundleTestAppleApp" DependsOnTargets="AppleBuild" />

-  <Target Name="_PrepareForAppleBuildAppOnHelix" DependsOnTargets="_PublishRuntimePack">
+  <Target Name="_PrepareForAppleBuildAppOnHelix">


Out of curiosity, does moving _PublishRuntimePack from this target's DependsOnTargets up to AppleBuildDependsOn change anything functionally?

If this target is the primary reason to have _PublishRuntimePack, I think it would be better to keep that dependency.

It shouldn't change the functionality. The primary reason for moving it to the AppleBuildDependsOn is to have a clear list of targets executed.

Do you think it should be reverted/added as a DependsOnTargets in _PrepareForAppleBuildAppOnHelix?

kotlarmilos · 2024-04-03T10:00:07Z

/azp run runtime-ioslike

azure-pipelines · 2024-04-03T10:00:16Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2024-04-03T10:02:20Z

/azp run runtime-ioslike

azure-pipelines · 2024-04-03T10:02:31Z

Azure Pipelines successfully started running 1 pipeline(s).

kotlarmilos · 2024-04-05T12:07:45Z

Closing this PR in favor of #100669 which has rebased commits.

ivanpovazan and others added 15 commits September 26, 2023 15:47

REVERT: Disable automatic CI runs

8e849e4

REVERT: Disable NativeAOT jobs

4c33ec3

Enable trimming for libraries and functional tests

ca292e8

REVERT: Disable runtime tests for now

60538ed

REVERT: Disable tvos lane

2fc0152

Disable building tests on Helix

cddf7cd

Try to trim on helix

4654eed

Forgot the extraHelixArgs

d436732

Merge remote-tracking branch 'upstream/main' into mono-trim-tests

44dd345

Publish / link on build machine and build app on helix

b5e2ebf

Throw tvos back in

6a297c2

Get paths right for local helix test build

136e440

Merge remote-tracking branch 'upstream/main' into mono-trim-tests

4315827

Merge remote-tracking branch 'upstream/main' into trim-ios-on-helix

629ef00

[infra] Add illink targets to trim app bundles on helix

bb3ae78

kotlarmilos added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure-mono os-ios Apple iOS labels Dec 19, 2023

kotlarmilos added this to the 9.0.0 milestone Dec 19, 2023

kotlarmilos self-assigned this Dec 19, 2023

[infra] Fix ILLink path on Helix

cfcf0e3

[infra] Fix ILLink path on Helix

af197a0

[infra] Fix ILLink path on Helix

1285fb6

build-analysis bot mentioned this pull request Mar 27, 2024

Assertion failed: (GetComponentSize() <= 2) || IsArray() #86273

Closed

kotlarmilos added 2 commits March 28, 2024 22:05

Add iOS-specific illink descriptor

fda7a6b

Merge branch 'dotnet:main' into trim-ios-on-helix

94ba5f4

This was referenced Mar 29, 2024

[wasm] Playwright failing #94240

Closed

Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928

Open

Browser SignalRClientTests failing in CI #100307

Closed

[wasi] Cannot find host wasmtime #100394

Closed

kotlarmilos requested review from ivanpovazan, simonrozsival and matouskozak March 29, 2024 09:07

mdh1418 reviewed Apr 2, 2024

View reviewed changes

Revert postBuildSteps changes

f2cc82e

mdh1418 reviewed Apr 2, 2024

View reviewed changes

kotlarmilos added 2 commits April 3, 2024 11:22

Merge branch 'main' into trim-ios-on-helix

ff3b586

Refactor proxy project to remove redundant props and items

7758009

Exclude _RemovedManagedAssembly from AppleAssembliesToBundle

d1377de

This was referenced Apr 3, 2024

[browser][mt] SignalRClientTests timeouts #100388

Closed

[wasm] SignalR tests timing out #100445

Closed

kotlarmilos closed this Apr 5, 2024

github-actions bot locked and limited conversation to collaborators May 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[infra] Enable trimming on Helix for Apple mobile #96169

[infra] Enable trimming on Helix for Apple mobile #96169

kotlarmilos commented Dec 19, 2023 •

edited

Loading

ghost commented Dec 19, 2023

Description

kotlarmilos commented Dec 19, 2023

azure-pipelines bot commented Dec 19, 2023

kotlarmilos commented Dec 19, 2023

azure-pipelines bot commented Dec 19, 2023

kotlarmilos commented Dec 19, 2023

azure-pipelines bot commented Dec 19, 2023

azure-pipelines bot commented Mar 27, 2024

kotlarmilos commented Mar 28, 2024

azure-pipelines bot commented Mar 28, 2024

kotlarmilos commented Mar 29, 2024

azure-pipelines bot commented Mar 29, 2024

mdh1418 Apr 2, 2024

kotlarmilos Apr 2, 2024

mdh1418 Apr 2, 2024

kotlarmilos Apr 3, 2024

mdh1418 Apr 2, 2024

mdh1418 Apr 2, 2024

kotlarmilos Apr 3, 2024

mdh1418 Apr 2, 2024

kotlarmilos Apr 3, 2024 •

edited

Loading

mdh1418 Apr 2, 2024

kotlarmilos Apr 3, 2024

mdh1418 Apr 2, 2024

kotlarmilos Apr 3, 2024

mdh1418 Apr 2, 2024

kotlarmilos Apr 3, 2024

kotlarmilos Apr 3, 2024

kotlarmilos commented Apr 3, 2024

azure-pipelines bot commented Apr 3, 2024

kotlarmilos commented Apr 3, 2024

azure-pipelines bot commented Apr 3, 2024

kotlarmilos commented Apr 5, 2024

		<OriginalPublishDir>$([System.IO.Path]::GetFullPath('$(TestRootDir)..\publish\'))</OriginalPublishDir>
		<ExtraFilesPath>$(OriginalPublishDir)..\extraFiles\</ExtraFilesPath>

		<ReferencePath Include="@(AppleReferenceSharedPathFiles->'$(MicrosoftNetCoreAppRuntimePackLibDir)%(FileName)%(Extension)')" />
		<ReferencePath Include="@(AppleReferenceExtraPathFiles->'$(ExtraFilesPath)%(FileName)%(Extension)')" />

[infra] Enable trimming on Helix for Apple mobile #96169

[infra] Enable trimming on Helix for Apple mobile #96169

Conversation

kotlarmilos commented Dec 19, 2023 • edited Loading

Description

ghost commented Dec 19, 2023

Description

kotlarmilos commented Dec 19, 2023

azure-pipelines bot commented Dec 19, 2023

kotlarmilos commented Dec 19, 2023

azure-pipelines bot commented Dec 19, 2023

kotlarmilos commented Dec 19, 2023

azure-pipelines bot commented Dec 19, 2023

azure-pipelines bot commented Mar 27, 2024

kotlarmilos commented Mar 28, 2024

azure-pipelines bot commented Mar 28, 2024

kotlarmilos commented Mar 29, 2024

azure-pipelines bot commented Mar 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kotlarmilos Apr 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kotlarmilos commented Apr 3, 2024

azure-pipelines bot commented Apr 3, 2024

kotlarmilos commented Apr 3, 2024

azure-pipelines bot commented Apr 3, 2024

kotlarmilos commented Apr 5, 2024

kotlarmilos commented Dec 19, 2023 •

edited

Loading

kotlarmilos Apr 3, 2024 •

edited

Loading