Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 encodings for IF_SVE_AR_4A, IF_SVE_AS_4A #96165

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Dec 19, 2023

Two more groups.

Both of these groups are encoded the same, except reg3 and reg4 swap positions in the second group.

Also fixed up the comment markers in codegenarm64test.cpp to be consistent.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 19, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Two more groups.

Both of these groups are encoded the same, except reg3 and reg4 swap positions in the second group.

Also fixed up the comment markers in codegenarm64test.cpp to be consistent.

Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@a74nh
Copy link
Contributor Author

a74nh commented Dec 19, 2023

@kunalspathak @BruceForstall. Probably my last one for 2023.

@a74nh a74nh marked this pull request as ready for review December 19, 2023 09:35
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Dec 19, 2023
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kunalspathak kunalspathak merged commit 1884956 into dotnet:main Dec 19, 2023
129 checks passed
@a74nh a74nh deleted the SVE_AR_4A_github branch December 20, 2023 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants