Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] enable finalizer thread, run most tests in threadpool #95783

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[browser][MT] enable finalizer thread, run most tests in threadpool #95783

merged 4 commits into from
Dec 12, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 8, 2023 •
edited
Loading

  • mono_wasm_init_finalizer_thread for MT runtime
  • run MT unit test from the thread pool thread, so that UI thread keeps responsive
  • -backgroundExec for Wasm test runner triggered via <_XUnitBackgroundExec>

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Dec 8, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Dec 8, 2023
@pavelsavara pavelsavara self-assigned this Dec 8, 2023
@ghost
Copy link

ghost commented Dec 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-VM-threading-mono, os-browser
Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

Surprisingly this change opens more opportunity for mono_thread_platform_create_thread failure in many unit tests.

System.ExecutionEngineException : mono_thread_platform_create_thread() failed
[11:14:05] info:    at System.Threading.Thread.ThrowThreadStartException(Exception ex)
[11:14:05] info:    at System.Threading.Thread.StartCore()

Log
Log
Log
Log
Log

This was referenced Dec 8, 2023
Open
Open
@pavelsavara
- mono_wasm_init_finalizer_thread for MT
b331283 
- -backgroundExec for Wasm test runner triggered via </_XUnitBackgroundExec>
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review December 8, 2023 17:25
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara changed the title [browser][MT] enable finalizer thread [browser][MT] enable finalizer thread, run most tests in threadpool Dec 11, 2023
@pavelsavara
Copy link
Member Author

CI failures are unrelated

@pavelsavara pavelsavara merged commit cea45aa into dotnet:main Dec 12, 2023
118 of 122 checks passed
@pavelsavara pavelsavara deleted the mono_gc_init_finalizer_thread branch December 12, 2023 10:10
@pavelsavara pavelsavara mentioned this pull request Dec 12, 2023
Closed
31 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @kg