Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Added SVE_GK_2A and SVE_GL_1A arm64 encodings #95707

Merged
merged 5 commits into from
Dec 8, 2023
Merged

JIT: Added SVE_GK_2A and SVE_GL_1A arm64 encodings #95707

merged 5 commits into from
Dec 8, 2023

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Dec 6, 2023 •
edited by kunalspathak
Loading

Contributes to #94549

Adds SVE_GK_2A and SVE_GL_1A arm64 encodings.

Capstone:

00E42245  aesd  z0.b, z0.b, z0.b
41E02245  aese  z1.b, z1.b, z2.b
A3E02345  sm4e  z3.s, z3.s, z5.s
00E42045  aesimc        z0.b, z0.b
05E02045  aesmc z5.b, z5.b

JitDisasm:

IN00a2: 00028C                    aesd    z0.b, z0.b, z0.b
IN00a3: 000290                    aese    z1.b, z1.b, z2.b
IN00a4: 000294                    sm4e    z3.s, z3.s, z5.s
IN00a5: 000298                    aesimc  z0.b, z0.b
IN00a6: 00029C                    aesmc   z5.b, z5.b

Screenshot of diff:

image

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 6, 2023
@ghost ghost assigned TIHan Dec 6, 2023
@ghost
Copy link

ghost commented Dec 6, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #94549

Adds SVE_GK_2A and SVE_GL_1A arm64 encodings.

Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@TIHan TIHan mentioned this pull request Dec 6, 2023
Closed
@TIHan
Copy link
Contributor Author

TIHan commented Dec 6, 2023

@dotnet/jit-contrib @kunalspathak @amanasifkhalid this is ready.

@build-analysis build-analysis bot mentioned this pull request Dec 7, 2023
Closed
kunalspathak
kunalspathak requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with 1 minor suggestion.

src/coreclr/jit/emitarm64.h Outdated Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Outdated Show resolved Hide resolved
@ghost ghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Dec 7, 2023
@TIHan
Copy link
Contributor Author

TIHan commented Dec 7, 2023

@kunalspathak this is ready again

kunalspathak
kunalspathak approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall added the arm-sve Work related to arm64 SVE/SVE2 support label Dec 7, 2023
@TIHan TIHan merged commit 31933a3 into dotnet:main Dec 8, 2023
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@TIHan TIHan

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TIHan @kunalspathak @BruceForstall