Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Added ARM64 SVE_GA_2A encoding #95435

Merged
merged 13 commits into from
Dec 4, 2023
Merged

JIT: Added ARM64 SVE_GA_2A encoding #95435

merged 13 commits into from
Dec 4, 2023

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Nov 30, 2023

Contributes to #94549

Adds SVE_GA_2A encoding

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2023
@ghost ghost assigned TIHan Nov 30, 2023
@ghost
Copy link

ghost commented Nov 30, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #94549

Adds SVE_GA_2A encoding

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr
Milestone: -

@TIHan TIHan mentioned this pull request Nov 30, 2023
Closed
@TIHan TIHan marked this pull request as ready for review December 1, 2023 20:45
@TIHan
Copy link
Contributor Author

TIHan commented Dec 1, 2023

@dotnet/jit-contrib @kunalspathak this is ready, pending CI.

Left: capstone, Right: JIT
image

kunalspathak
kunalspathak approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
src/coreclr/jit/codegenarm64.cpp Show resolved Hide resolved
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Dec 2, 2023
@TIHan
Copy link
Contributor Author

TIHan commented Dec 4, 2023

Merging, only change was formatting and the additional emitter test cases. Current failures are not related.

@TIHan TIHan merged commit 0c513d9 into dotnet:main Dec 4, 2023
120 of 129 checks passed
@TIHan TIHan deleted the SVE_GA_2A branch December 4, 2023 22:25
@EgorBo EgorBo mentioned this pull request Dec 14, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

@BruceForstall BruceForstall BruceForstall left review comments

@a74nh a74nh a74nh left review comments

Assignees

@TIHan TIHan

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TIHan @a74nh @BruceForstall @kunalspathak