-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasi] Simplify, and clean up target for bundled resource generation #95426
Conversation
radical
commented
Nov 29, 2023
- [wasi] EmitBuildBase: Output an item for the bundle file also. This is correct as it represents all the outputs
- [wasi] WasiApp.Native.targets: Simplify target for bundling resources in single file bundle, and remove special cased way of handling bundlefiles
- [wasi] EmitBundleBase: ReleaseCores once the execution is done, as msbuild does not seem to release them between batched task invocations
- [wasi] Makefile: add build-packages target
…s correct as it represents all the outputs
… in single file bundle, and remove special cased way of handling bundlefiles
…build does not seem to release them between batched task invocations
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
@steveisok @mdh1418 Does the addition of the |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
I think this could be changed runtime/src/mono/msbuild/common/LibraryBuilder.targets Lines 22 to 23 in 7532f65
@(BundledSources) was originally added to include the BundleFile , but if we are emitting BundleFile itself as part of the Outputs, then it will be covered by %(_BundledResources.DestinationFile) . (but maybe it wouldn't have duplicates right?)
I think the original intent was for the BundledResources Output parameter to solely be resources that would be processed into the preallocated |
Hm I'll add a new output like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than figuring out if we should include the BundleFile
in the same Output group as BundledResources
or not, looks good to me!
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
Failures are all known issues. |