Disallow arrays of System.Void #94835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
added
the
breaking-change
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
jkotas
added
area-TypeSystem-coreclr
and removed
needs-breaking-change-doc-created
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
reviewed
Nov 16, 2023
The CoreCLR type loader allowed creating arrays of System.Void. Many operations with these invalid array types failed, often in inscrutable ways. For example, GetInterfaces() call failed with type load exception of IEnumerable type. The exact failure modes are different between runtimes. It is better to disallow creating these invalid array types in the first place, across all runtimes, to make the behavior robust and consistent. Related to dotnet#88620 Fixes dotnet#94086
jkotas
commented
Nov 17, 2023
| @@ -1170,12 +1170,8 @@ mono_class_create_bounded_array (MonoClass *eclass, guint32 rank, gboolean bound | |||
| klass->rank = GUINT32_TO_UINT8 (rank); | |||
| klass->element_class = eclass; | |||
|
|
|||
| if (m_class_get_byval_arg (eclass)->type == MONO_TYPE_TYPEDBYREF) { | |||
There was a problem hiding this comment.
TypedReference is byreflike type, so it is not necessary to check for it explicitly here.
jkotas
requested review from
vargaz,
thaystg and
MichalStrehovsky
as code owners
|
I thought this was always disallowed. |
Does that work with open generic types or pointers? |
Yes, it does. Pointers are special cased here: |
This was referenced Nov 17, 2023
|
The mono changes look ok to me. |
|
Breaking change issue dotnet/docs#38311 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoreCLR type loader allowed creating arrays of
System.Void. Many operations with these invalid array types failed, often in inscrutable ways. For example,GetInterfaces()call failed with type load exception ofIEnumerable<void>type. The exact failure modes are different between runtimes.It is better to disallow creating these invalid array types in the first place, across all runtimes, to make the behavior robust and consistent.
Related to #88620
Fixes #94086