Disallow inlining Main #94449
Merged
Disallow inlining Main #94449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we compile managed code, `Main` is not the actual spot where execution of managed code starts. Instead it's the `StartupCodeMain` method that the compiler generates. This method is responsible for initializing the managed environment, calling `Main` and tearing down the environment. If `Main` is short enough, sometimes it gets inlined into `StartupCodeMain` this has bad impact on diagnostics (don't see `Main` in stack traces, can't set breakpoints). Pretend it was marked `NoInlining`.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsWhen we compile managed code, Cc @dotnet/ilc-contrib
|
ghost
assigned
This was referenced Nov 7, 2023
|
Yeah it was annoying that |
EgorBo
reviewed
Nov 7, 2023
jkotas
reviewed
Nov 7, 2023
jkotas
reviewed
Nov 9, 2023
src/coreclr/tools/aot/ILCompiler.RyuJit/JitInterface/CorInfoImpl.RyuJit.cs
Outdated
Show resolved
Hide resolved
…pl.RyuJit.cs Co-authored-by: Jan Kotas <[email protected]>
src/coreclr/tools/aot/ILCompiler.Compiler/IL/Stubs/StartupCode/StartupCodeMainMethod.cs
Outdated
Show resolved
Hide resolved
…/StartupCodeMainMethod.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we compile managed code,
Mainis not the actual spot where execution of managed code starts. Instead it's theStartupCodeMainmethod that the compiler generates. This method is responsible for initializing the managed environment, callingMainand tearing down the environment. IfMainis short enough, sometimes it gets inlined intoStartupCodeMainthis has bad impact on diagnostics (don't seeMainin stack traces, can't set breakpoints). Pretend it was markedNoInlining.Cc @dotnet/ilc-contrib