Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Remove [EditorBrowsable(Never)] from [InlineArray], add XML docs #94343

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2023

Backport of #94308 to release/8.0-staging

/cc @stephentoub @Sergio0694

Customer Impact

[InlineArray] is a new feature we would like developers to use, but it's currently hidden from IntelliSense due to an errant attribute on the type. This just removes the attribute so that the type shows up in the IDE when a developer tries to use it.

Testing

There's no functional impact to the change.

Risk

As low as it gets.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #94308 to release/8.0-staging

/cc @stephentoub @Sergio0694

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Runtime.CompilerServices, new-api-needs-documentation

Milestone: -

@stephentoub stephentoub added Servicing-consider Issue for next servicing release review and removed new-api-needs-documentation labels Nov 3, 2023
@teo-tsirpanis teo-tsirpanis added this to the 8.0.x milestone Nov 4, 2023
@stephentoub stephentoub added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 6, 2023
@carlossanlop
Copy link
Member

Friendly reminder: If you'd like this to be included in the December release, please merge it before Tuesday November 14th EOD (Code Complete).

@tannergooding
Copy link
Member

@stephentoub, is there anything blocking this from being merged given its marked as servicing-approved?

@stephentoub
Copy link
Member

I just didn't remember whether I was supposed to merge or wait for Carlos.

@stephentoub
Copy link
Member

Plus someone needs to approve it.

@stephentoub stephentoub merged commit 87d0f45 into release/8.0-staging Nov 10, 2023
171 of 179 checks passed
@stephentoub stephentoub deleted the backport/pr-94308-to-release/8.0-staging branch November 10, 2023 01:37
@danmoseley
Copy link
Member

Does this require we update the ref pack to update intellisense, and do we generally do that for servicing?

@stephentoub
Copy link
Member

I'm not concerned about the IntelliSense changes; they just came along for the ride. But presumably the ref pack needs to be updated for the ref assembly to pick up the removed attribute, and I believe we do update the ref pack in servicing... isn't that how we end up distributing source generators?

@carlossanlop carlossanlop modified the milestones: 8.0.x, 8.0.1 Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants