Enable aligned_alloc on macOS #94298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #54296
|
jkotas
commented
Nov 2, 2023
jkotas
commented
Nov 2, 2023
| @@ -608,14 +607,10 @@ elseif(CLR_CMAKE_TARGET_ANDROID) | |||
| elseif(CLR_CMAKE_TARGET_BROWSER OR CLR_CMAKE_TARGET_WASI) | |||
| set(HAVE_FORK 0) | |||
| else() | |||
| if(CLR_CMAKE_TARGET_OSX) | |||
| unset(HAVE_ALIGNED_ALLOC) # only exists on OSX 10.15+ | |||
There was a problem hiding this comment.
Our minimum supported macOS version is 10.15 so this block is no longer needed.
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsFixes #54296
|
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kotlarmilos @ivanpovazan Could you please review and approve? |
ivanpovazan
reviewed
Nov 13, 2023
src/native/libs/configure.cmake
Outdated
| @@ -581,23 +581,22 @@ if(CLR_CMAKE_TARGET_IOS) | |||
| # Manually set results from check_c_source_runs() since it's not possible to actually run it during CMake configure checking | |||
| unset(HAVE_SHM_OPEN_THAT_WORKS_WELL_ENOUGH_WITH_MMAP) | |||
| unset(HAVE_ALIGNED_ALLOC) # only exists on iOS 13+ | |||
| unset(HAVE_CLOCK_MONOTONIC) # only exists on iOS 10+ | |||
| unset(HAVE_CLOCK_REALTIME) # only exists on iOS 10+ | |||
| set(HAVE_CLOCK_MONOTONIC) | |||
There was a problem hiding this comment.
@akoeplinger could this change cause issues related to: #73650
am11
reviewed
Nov 13, 2023
Co-authored-by: Adeel Mujahid <[email protected]>
jkotas
commented
Nov 13, 2023
jkotas
commented
Nov 13, 2023
kotlarmilos
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54296