Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64: Fix Vector64x2/3/4 API comments. Minor cleanup in AdvSimd. #94188

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Oct 30, 2023

This is a non-functional change. It fixes a few comments in the recent VectorLoad APIs that we added, and does some minor cleanup in AdvSimd by removing the fully qualified use of Vector64 and Vector128.

@ghost
Copy link

ghost commented Oct 30, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a non-functional change. It fixes a few comments in the recent VectorLoad APIs that we added, and does some minor cleanup in AdvSimd by removing the fully qualified use of Vector64 and Vector128.

Author: TIHan
Assignees: TIHan
Labels:

area-System.Runtime.Intrinsics

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Oct 30, 2023

@dotnet/jit-contrib @kunalspathak this is ready.

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning it up.

@TIHan TIHan merged commit 920cd6e into dotnet:main Oct 31, 2023
173 of 175 checks passed
@TIHan TIHan deleted the arm64-load-vector-cleanup branch October 31, 2023 01:58
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants