Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test returning 100 unconditionally #94146

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix test returning 100 unconditionally #94146

merged 1 commit into from
Oct 30, 2023

Conversation

gbalykov
Copy link
Member

Xunit error XUW1002: Tests should not unconditionally return 100. Convert to a void return.

Related change: #93834

cc @EgorBo @clamp03 @t-mustafin

@gbalykov
Fix test returning 100 unconditionally
c37f5fd 
Xunit error XUW1002: Tests should not unconditionally return 100. Convert to a void return.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 29, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 29, 2023
@ghost
Copy link

ghost commented Oct 29, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Xunit error XUW1002: Tests should not unconditionally return 100. Convert to a void return.

Related change: #93834

cc @EgorBo @clamp03 @t-mustafin

Author: gbalykov
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@gbalykov
Copy link
Member Author

@EgorBo please take a look, without this change clr tests build on main fails

EgorBo
EgorBo approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EgorBo EgorBo merged commit 7420ee7 into dotnet:main Oct 30, 2023
101 checks passed
@jakobbotsch
Copy link
Member

@markples Is it expected that CI doesn't fail for something like this?

@markples
Copy link
Member

Is it expected that CI doesn't fail for something like this?

I would have expected it to fail, and I think I've seen them in CI before, so I'm not sure what is different here. My guess is that it has to two with the two-pass (anycpu vs per-target) nature of the build in CI vs local builds. I don't see anything obvious (to me anyway) in the history for src\tests\Directory.Build.targets or in XUnitWrapperGenerator. It might also be related to XUnitWrapperGenerator being (ab)used to do some checks in addition to generating the wrappers; Jeremy suggested splitting that out.

@trylek @jkoritzinsky @ivdiazsa any ideas here?

@markples markples mentioned this pull request Oct 30, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@gbalykov gbalykov

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbalykov @jakobbotsch @markples @EgorBo