Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to resolve x64 libc++ being included with linux-arm64 #93027

Conversation

directhex
Copy link
Contributor

... linux-arm64 to browser-wasm cross-compilers, due to incorrect assumption that the build architecture should be used for wasm cases.

Closes: #93015

browser-wasm cross-compilers, due to incorrect assumption that
the build architecture should be used for wasm cases.
Closes: dotnet#93015
@directhex directhex marked this pull request as ready for review October 4, 2023 21:01
@directhex
Copy link
Contributor Author

This appears correct in the binlog

@directhex
Copy link
Contributor Author

Confirmed on the official job that this fix fixes the problem. libc++ now matches architecture on linux-arm64

@directhex directhex merged commit b7448cd into dotnet:main Oct 5, 2023
94 of 97 checks passed
@directhex
Copy link
Contributor Author

Failures unrelated, and one check is stuck, merging.

@directhex
Copy link
Contributor Author

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6419908236

@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[release/8.0] Wrong architecture libc++ bundled with wasm cross-compilers on linux-arm64
2 participants