[wasm] Fix regressed file sizes for blazor #92664

radical · 2023-09-26T20:17:52Z

[wasm] build: Revert to older behavior for WasmNativeStrip

The earlier change was done in 26ae097,
which changed to pass -g to the link step also. But that resulted in
increased native file sizes.

[wasm] Add getter for __indirect_function_table
[wasm] cleanup corresponding tests
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect

Issue: Issue: dotnet/perf-autofiling-issues#20642

.. so that can work even if it gets renamed during minimization.

The earlier change was done in 678fd6a, which changed to pass `-g` to the link step also. But that resulted in increased native file sizes. Changed sizes for the `minimum blazor template - publish` scenario: ``` | Last rc1 run | With the change ----------------------------------------------------------|----------------- |------------------ SOD - Minimum Blazor Template - Publish |8590723.000 bytes |7889806.000 bytes Total Uncompressed _framework |4304274.000 bytes |4202273.000 bytes pub/wwwroot/_framework/dotnet.js |35722.000 bytes |35838.000 bytes pub/wwwroot/_framework/dotnet.native.8.0.0-VERSION.js |239307.000 bytes |134566.000 bytes pub/wwwroot/_framework/dotnet.native.wasm |1174394.000 bytes |1148841.000 bytes pub/wwwroot/_framework/dotnet.runtime.8.0.0-VERSION.js |221356.000 bytes |221712.000 bytes ``` (cherry picked from commit ae93e81)

(cherry picked from commit 0207d60)

(cherry picked from commit 91379dd)

ghost · 2023-09-26T20:18:04Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

[wasm] Add getter for __indirect_function_table
[wasm] build: Revert to older behavior for WasmNativeStrip
[wasm] cleanup corresponding tests
[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect

Author:	radical
Assignees:	-
Labels:	`arch-wasm`
Milestone:	-

radical · 2023-09-26T20:30:25Z

/azp run runtime-wasm-perf

azure-pipelines · 2023-09-26T20:30:39Z

Azure Pipelines successfully started running 1 pipeline(s).

src/mono/wasm/runtime/types/internal.ts

src/mono/wasm/runtime/es6/dotnet.es6.pre.js

radical · 2023-09-27T21:58:03Z

After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, ~~library~~ all the tests are failing with:

fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
          at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
          at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
          at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n    at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n    at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n    at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.

kg · 2023-09-27T22:05:23Z

After the change to move getWasmIndirectFunctionTable to only be before the runtime is created, ~~library~~ all the tests are failing with:

fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.runtime.js 2:12344 "MONO_WASM: onRuntimeInitializedAsync() failed" TypeError: t.getWasmIndirectFunctionTable is not a function
          at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)
          at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)
          at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955
fail: [out of order message from the browser]: http://127.0.0.1:36071/_framework/dotnet.js 2:917 "MONO_WASM: TypeError: t.getWasmIndirectFunctionTable is not a function\n    at br (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:55253)\n    at zr (http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:60544)\n    at http://127.0.0.1:36071/_framework/dotnet.runtime.js:3:214955"

log.

I guess I put it in both places because it was actually necessary, and I forgot :-)

pavelsavara · 2023-11-29T09:47:58Z

need help ?

radical · 2023-11-29T21:10:18Z

need help ?

Any suggestions on a fix? The alternative would be to disable the failing tests which are essentially for Debug+AOT, and Debug+relink. We could ignore debug+aot for now, but debug+relink is likely more common because we would relink if you had any native references too.

But this PR will help the sizes.

pavelsavara · 2023-11-30T08:32:59Z

Any suggestions on a fix?

Still this, right ?

Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]

 [error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found
            at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)
            at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838
            at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

radical · 2023-11-30T08:33:49Z

Any suggestions on a fix?

Still this, right ?


Wasm.Build.Tests.Blazor.SimpleRunTests.BlazorPublishRunTest(config: "Debug", aot: True) [FAIL]



 [error] MONO_WASM: onRuntimeInitializedAsync() failed Error: raw cwrap mono_jiterp_placeholder_trace not found

            at Ir (http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:58604)

            at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:214838

            at http://127.0.0.1:35275/_framework/dotnet.runtime.9.0.0-ci.uxcbg0k114.js:3:215122

Yes

pavelsavara · 2023-11-30T08:52:19Z

I have this untested theory:

I think this is not about AOT, but about WasmBuildNative being triggered with some optimization level which mangles symbols.

It fails in getRawCwrap which uses un-mangled symbol names.
mono_jiterp_placeholder_trace is just coincidence, because it's the first thing requested.

We have this un-mangling logic in createWasmImportStubsFrom and replace_linker_placeholders for wasm imports. Maybe we need same thing for wasm exports ?

pavelsavara · 2023-11-30T08:55:06Z

Printing full list of Module["asm"] would help to debug it.

radical · 2023-11-30T08:55:10Z

Relink/aot with an optimization level and -g . This happens only for debug config.

Dunno about the details that you mentioned.

radical · 2023-12-06T07:54:09Z

#95613 seems to have fixed the failures! Thanks @kg, @pavelsavara!

radical · 2023-12-06T08:05:43Z

/azp run runtime-wasm

azure-pipelines · 2023-12-06T08:06:02Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2023-12-06T08:07:04Z

@microsoft-github-policy-service rerun

radical · 2023-12-06T10:00:57Z

Failures are known issues.

radical · 2023-12-06T10:02:38Z

@microsoft-github-policy-service rerun

radical · 2023-12-06T10:34:57Z

@dotnet-github-policy-service rerun

radical · 2023-12-06T10:35:42Z

@dotnet-policy-service rerun

radekdoulik · 2023-12-07T11:06:49Z

great work

Blazor size regression was fixed by: ``` commit ec31705 Author: Ankit Jain <[email protected]> Date: Wed Dec 6 05:36:59 2023 -0500 [wasm] Fix regressed file sizes for blazor (dotnet#92664) ``` .. but a subsequent PR created close to that undid some of the changes: ``` commit a128c15 Author: Ankit Jain <[email protected]> Date: Mon Dec 11 15:45:58 2023 -0500 [wasm/wasi] Consolidate build targets (dotnet#95775) ``` Essentially, `-g` was being passed to the link, and compile-bc steps. Found in dotnet/perf-autofiling-issues#25891 .

* [wasm/wasi] Fix size regression Blazor size regression was fixed by: ``` commit ec31705 Author: Ankit Jain <[email protected]> Date: Wed Dec 6 05:36:59 2023 -0500 [wasm] Fix regressed file sizes for blazor (#92664) ``` .. but a subsequent PR created close to that undid some of the changes: ``` commit a128c15 Author: Ankit Jain <[email protected]> Date: Mon Dec 11 15:45:58 2023 -0500 [wasm/wasi] Consolidate build targets (#95775) ``` Essentially, `-g` was being passed to the link, and compile-bc steps. Found in dotnet/perf-autofiling-issues#25891 . * [wasm] Add flag missed in the consolidate PR

radical added 4 commits September 26, 2023 16:17

[wasm] Add getter for __indirect_function_table

70a900e

.. so that can work even if it gets renamed during minimization.

[wasm] cleanup corresponding tests

d84ecf9

(cherry picked from commit 0207d60)

[wasm] Remove WasmNativeStrip from wasm.proj as it will have no effect

dd5fc7c

(cherry picked from commit 91379dd)

radical requested review from lewing, pavelsavara and kg as code owners September 26, 2023 20:17

radical added the arch-wasm WebAssembly architecture label Sep 26, 2023

dotnet-issue-labeler bot added the area-Build-mono label Sep 26, 2023

ghost assigned radical Sep 26, 2023

radical changed the title ~~wasm native strip main~~ [wasm] Fix regressed file sizes for blazor Sep 26, 2023

disable non-wasm perf builds

519f136

Merge remote-tracking branch 'origin/main' into wasm-native-strip-main

ac41670

kg reviewed Sep 27, 2023

View reviewed changes

src/mono/wasm/runtime/types/internal.ts Outdated Show resolved Hide resolved

kg reviewed Sep 27, 2023

View reviewed changes

src/mono/wasm/runtime/es6/dotnet.es6.pre.js Show resolved Hide resolved

kg approved these changes Sep 27, 2023

View reviewed changes

address feedback from Katelyn Gadd

1ea3c61

This was referenced Sep 27, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

Build crashes in System.Runtime.Serialization.SerializationGuard #92007

Closed

radical added 2 commits September 27, 2023 16:37

address review feedback

68e954d

remove debug bits

e64ccf6

radical mentioned this pull request Sep 27, 2023

[release/8.0][wasm] Define getWasmIndirectFunctionTable before initializing the #92683

Closed

radical added 3 commits September 27, 2023 18:10

Merge remote-tracking branch 'origin/main' into wasm-native-strip-main

44d6bc3

Merge branch 'dotnet:main' into wasm-native-strip-main

85c0af8

fix build

f835b6c

This was referenced Nov 8, 2023

[wasm] Runtime tests' build gets terminated with exited with code 137 #94077

Closed

[wasm] Playwright failing #94240

Closed

radical added 2 commits November 20, 2023 22:38

Merge branch 'dotnet:main' into wasm-native-strip-main

1b12865

Merge remote-tracking branch 'origin/main' into wasm-native-strip-main

e137f3e

pavelsavara mentioned this pull request Dec 5, 2023

[wasm] Suppress export name minification #95613

Merged

Merge remote-tracking branch 'origin/main' into wasm-native-strip-main

d3a4032

This was referenced Dec 6, 2023

[wasm][debugger] Debugger tests getting randomly aborted on CI #89409

Open

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

radical merged commit ec31705 into dotnet:main Dec 6, 2023
45 of 49 checks passed

radical deleted the wasm-native-strip-main branch December 6, 2023 10:37

github-actions bot locked and limited conversation to collaborators Jan 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] Fix regressed file sizes for blazor #92664

[wasm] Fix regressed file sizes for blazor #92664

radical commented Sep 26, 2023 •

edited

Loading

ghost commented Sep 26, 2023

radical commented Sep 26, 2023

azure-pipelines bot commented Sep 26, 2023

radical commented Sep 27, 2023 •

edited

Loading

kg commented Sep 27, 2023

pavelsavara commented Nov 29, 2023

radical commented Nov 29, 2023

pavelsavara commented Nov 30, 2023

radical commented Nov 30, 2023

pavelsavara commented Nov 30, 2023

pavelsavara commented Nov 30, 2023

radical commented Nov 30, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

azure-pipelines bot commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radekdoulik commented Dec 7, 2023 •

edited

Loading

[wasm] Fix regressed file sizes for blazor #92664

[wasm] Fix regressed file sizes for blazor #92664

Conversation

radical commented Sep 26, 2023 • edited Loading

ghost commented Sep 26, 2023

radical commented Sep 26, 2023

azure-pipelines bot commented Sep 26, 2023

radical commented Sep 27, 2023 • edited Loading

kg commented Sep 27, 2023

pavelsavara commented Nov 29, 2023

radical commented Nov 29, 2023

pavelsavara commented Nov 30, 2023

radical commented Nov 30, 2023

pavelsavara commented Nov 30, 2023

pavelsavara commented Nov 30, 2023

radical commented Nov 30, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

azure-pipelines bot commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radical commented Dec 6, 2023

radekdoulik commented Dec 7, 2023 • edited Loading

radical commented Sep 26, 2023 •

edited

Loading

radical commented Sep 27, 2023 •

edited

Loading

radekdoulik commented Dec 7, 2023 •

edited

Loading