[release/8.0] Update dependencies from dotnet/roslyn #91913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…911.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23461.1
…911.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23461.4
This was referenced Sep 12, 2023
…912.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.1
carlossanlop
approved these changes
Sep 12, 2023
…912.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.2
…912.3 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.3
…912.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.4
…912.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.6
…912.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.7
…912.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.8
…912.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.9
…912.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.8.0-3.23459.2 -> To Version 4.8.0-3.23462.10
ericstj
requested changes
Sep 13, 2023
There was a problem hiding this comment.
Do not merge this PR until we've addressed the failing reflection tests.
System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected
Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual: Public | ClassSemanticsMask | Abstract | BeforeFieldInit
Stack trace
at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
at System.Runtime.Tests!<BaseAddress>+0x1614bf0
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
ericstj
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
I think this should fix the failing reflection tests @steveharter @AlekseyTs
|
I merged the revert PR. I am now restarting the CI of the PRs that caught that failure so that they get better results. |
steveharter
approved these changes
Sep 14, 2023
|
CI is good again. Merging. cc @ericstj |
carlossanlop
deleted the
darc-release/8.0-71360d31-7c01-4d25-a66c-aafc442afc94
branch
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn