-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Fix Dispose and SendData Race on Http3 Test #91690
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #91291 to release/8.0 /cc @liveans Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
Show resolved
Hide resolved
Failures are unrelated to this PR. Failures (updated by @karelz):
Rerunning the failures |
Test only change, I approve - @artl93 ready for your approval |
M2 approved. |
Adding Servicing-Approved label per @artl93's approval above. |
Yes, thank you! |
Backport of #91291 to release/8.0
Fixes #87552
/cc @liveans
Customer Impact
Test only change to decrease noise in CI.
Fixes test
System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ServerSendsTrailingHeaders_Success
, which failed 3x per day (but passed on rerun).Testing
CI in main had no hits in 2 days - previously failed 3x per day.
Risk
No risk, the test only change