Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Native AOT outerloop tests to their own pipeline #91684

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

agocke
Copy link
Member

@agocke agocke commented Sep 6, 2023

Native AOT tests are regularly queued on their own and are very reliable. By putting the tests in their own queue we can both queue the Native AOT tests individually and ensure that the pipeline stays green.

Native AOT tests are regularly queued on their own and are very
reliable. By putting the tests in their own queue we can both
queue the Native AOT tests individually and ensure that the pipeline
stays green.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 6, 2023
@ghost ghost assigned agocke Sep 6, 2023
@agocke
Copy link
Member Author

agocke commented Sep 6, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but obviously we shouldn't merge before we validate it works.

- THIRD-PARTY-NOTICES.TXT

schedules:
- cron: "0 9,21 * * *" # run at 9:00 and 21:00 (UTC) which is 1:00 and 13:00 (PST).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you ask the first responders to create a pipeline definition for this in AzDO, could you also ask if there's a guidance on how to spread out scheduled pipeline runs? I see this one would happen at the same time as extra-platforms. Maybe we should spread them out?


# This pipeline includes the Native AOT tests that we don't have resources to
# run on every PR but that we want to still have test coverage, we run this
# pipeline on a schedule and also developers can run it via /azp run command on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification, to initiate a build manually, one would need to do: /azp run runtime-nativeaot-outerloop ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that's the intent

@ivanpovazan
Copy link
Member

/cc: @kotlarmilos

- linux_arm64
- linux_musl_x64
jobParameters:
testGroup: innerloop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the test group still innerloop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. This is a terminology issue, but even though this pipeline is "outer-loop", the test group is "inner loop." I could be wrong about that, though.

@agocke agocke merged commit b667f25 into dotnet:main Sep 20, 2023
208 of 232 checks passed
@agocke agocke deleted the move-nativeaot-extra-plat branch September 20, 2023 23:49
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants