-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Native AOT outerloop tests to their own pipeline #91684
Conversation
Native AOT tests are regularly queued on their own and are very reliable. By putting the tests in their own queue we can both queue the Native AOT tests individually and ensure that the pipeline stays green.
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but obviously we shouldn't merge before we validate it works.
- THIRD-PARTY-NOTICES.TXT | ||
|
||
schedules: | ||
- cron: "0 9,21 * * *" # run at 9:00 and 21:00 (UTC) which is 1:00 and 13:00 (PST). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you ask the first responders to create a pipeline definition for this in AzDO, could you also ask if there's a guidance on how to spread out scheduled pipeline runs? I see this one would happen at the same time as extra-platforms. Maybe we should spread them out?
|
||
# This pipeline includes the Native AOT tests that we don't have resources to | ||
# run on every PR but that we want to still have test coverage, we run this | ||
# pipeline on a schedule and also developers can run it via /azp run command on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a clarification, to initiate a build manually, one would need to do: /azp run runtime-nativeaot-outerloop
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that's the intent
/cc: @kotlarmilos |
- linux_arm64 | ||
- linux_musl_x64 | ||
jobParameters: | ||
testGroup: innerloop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the test group still innerloop
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. This is a terminology issue, but even though this pipeline is "outer-loop", the test group is "inner loop." I could be wrong about that, though.
Native AOT tests are regularly queued on their own and are very reliable. By putting the tests in their own queue we can both queue the Native AOT tests individually and ensure that the pipeline stays green.