[release/8.0] Fix diagnostic creation to ensure including the URI #91145
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #91123 to release/8.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
tarekgh
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsBackport of #91123 to release/8.0 /cc @tarekgh Customer ImpactFor users utilizing Logging or Interop source generators, there is a chance that certain diagnostics may lack URI links directing to the issues. The diagnostics that currently lack URI links were introduced recently and will not consistently display the URI, just like the other diagnostics do. Testingregression tests RiskThe risk is minimal, as the only alteration made is to ensure the addition of URI links to the generated diagnostics. IMPORTANT: If this backport is for a servicing release, please verify that:
|
tarekgh
added
Servicing-approved
|
@carlossanlop can you please help merging this one? |
ghost
locked as resolved and limited conversation to collaborators
Backport of #91123 to release/8.0
/cc @tarekgh
Customer Impact
For users utilizing Logging or Interop source generators, there is a chance that certain diagnostics may lack URI links directing to the issues. The diagnostics that currently lack URI links were introduced recently and will not consistently display the URI, just like the other diagnostics do.
Testing
regression tests
Risk
The risk is minimal, as the only alteration made is to ensure the addition of URI links to the generated diagnostics.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.