Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] [mono] Add a --path command line argument as an alternative to MONO_P… #90678

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 16, 2023

Description

Backport of #90544 to release/8.0-rc1

This PR adds an additional command line argument --path as an alternative to MONO_PATH env variable. The MONO_PATH is used to point to the directory where all the assemblies are for the AOT compiler. If there are multiple directories, they are split by colon. When building an apple mobile app remotely from Windows, the intermediate and output path is set to a full Windows path which contains colon. The expected behavior was to locate all assemblies required for AOT compilation, but instead, the AOT compiler exited with an error code.

The fix for this issue includes adding the new command line argument --path which can be specified multiple times.

Customer Impact

The issue was discovered by a team member. The fix should help resolving #90422, which should allow customers building apple mobile apps on a remote Mac using Windows.

Testing

Manual testing was performed, ensuring that the AOT compiler can resolve assemblies from paths passed using the --path command line argument, which may contain colon symbols. The issue has been reproduced locally, and has been fixed.

Risk

Low risk. This change involves adding a new command line argument to the AOT compiler.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

The change doesn't affect code that ships in a NuGet package.

@lewing lewing added the Servicing-consider Issue for next servicing release review label Aug 16, 2023
@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Aug 16, 2023
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 16, 2023
@carlossanlop
Copy link
Member

CI failure is an execution timeout:

[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 2700 seconds and was killed
['System.Runtime.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@carlossanlop carlossanlop merged commit a37d138 into release/8.0-rc1 Aug 16, 2023
103 of 112 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90544-to-release/8.0-rc1 branch August 16, 2023 20:22
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants