[release/8.0-rc1] Fix ToFrozenDictionary(selectors) on empty sources #90599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
As part of optimizing construction, the empty check when using ToFrozenDictionary taking selector delegates was skipped, leading to later failures when an empty source is used.
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsBackport of #90595 to release/8.0-rc1 /cc @stephentoub Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
stephentoub
added
Servicing-consider
ericstj
approved these changes
Aug 15, 2023
stephentoub
force-pushed
the
backport/pr-90595-to-release/8.0-rc1
branch
from
60d7f12
to
70c9f16
Compare
eiriktsarpalis
approved these changes
Aug 15, 2023
|
Failure is #90309 @carlossanlop, can you help merge? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90595 to release/8.0-rc1
/cc @stephentoub
Customer Impact
The new
ToFrozenDictionaryextension method erroneously throws an exception when used with an empty source and a key value selector, e.g.will throw if
sourcehas no elements.Testing
Added new tests to cover these overloads with an empty source.
Risk
Minimal. The fix just routes these overloads through an existing one.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.