Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Fix InlineArray tests on android platforms #90583

Merged
merged 16 commits into from
Aug 16, 2023

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Aug 15, 2023

This PR renames the InvalidCSharp assembly to have unique name in the test app bundle. On android platforms, all assemblies are copied to the root directory, which may cause overriding assemblies with the same name.

Screenshot 2023-08-16 at 13 05 03

Here is a tracking issue to ensure that these cases remain valid in the future: #90661

Fixes #90398

@kotlarmilos kotlarmilos added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it os-android area-Infrastructure-mono labels Aug 15, 2023
@kotlarmilos kotlarmilos added this to the 9.0.0 milestone Aug 15, 2023
@kotlarmilos kotlarmilos self-assigned this Aug 15, 2023
@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR tests InlineArray execution on android device and emulators.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

NO-MERGE, NO-REVIEW, os-android, area-Infrastructure-mono

Milestone: 9.0.0

@kotlarmilos
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos kotlarmilos changed the title [mono] Run InlineArray tests on the CI [mono] Fix InlineArray tests on android platforms Aug 16, 2023
@kotlarmilos kotlarmilos removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 16, 2023
@kotlarmilos kotlarmilos marked this pull request as ready for review August 16, 2023 11:25
@kotlarmilos
Copy link
Member Author

@SamMonoRT Do we want to backport this to .NET8?

@kotlarmilos
Copy link
Member Author

/azp run runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos kotlarmilos merged commit 7a11cff into dotnet:main Aug 16, 2023
@kotlarmilos
Copy link
Member Author

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5881807413

@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InlineArray[Valid]/[Invalid] Runtime tests are failing for Mono miniJIT and interpreter
5 participants