Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Fix all the issues related to enabling WasmStripILAfterAOT #90436

Merged
merged 79 commits into from
Nov 13, 2023
Merged

[Mono] Fix all the issues related to enabling WasmStripILAfterAOT #90436

merged 79 commits into from
Nov 13, 2023

Commits on Aug 11, 2023

  1. Enable IL trim for WASM by default

    @fanyang-mono
    fanyang-mono committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    68dd32a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Make ILStrip available for local build

    @fanyang-mono
    fanyang-mono committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    7507121 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Make all calling another method go through the logic to see if it cou… 

    …ld call an AOT'ed version of it before trying to interp compile it
    @fanyang-mono
    fanyang-mono committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b02a8e5 View commit details
    Browse the repository at this point in the history

  2. Add back accidentally removed line of code

    @fanyang-mono
    fanyang-mono committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1f7b587 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Update test to accommodate IL trim with WASM AOT

    @fanyang-mono
    fanyang-mono committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    83cd21e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Move jit_call_can_be_supported to mini-runtime, so it doesn't depends… 

    … on the value of mono_use_interpreter
    @fanyang-mono
    fanyang-mono committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1f2f152 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Update var name

    @fanyang-mono
    fanyang-mono committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d9027dd View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Attempt to fix rebuild test failures

    @fanyang-mono
    fanyang-mono committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    481db67 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Attempt to fix the file open issue with unicode on windows

    @fanyang-mono
    fanyang-mono committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    aee3e0c View commit details
    Browse the repository at this point in the history

  2. Attempt to fix unicode issue #2

    @fanyang-mono
    fanyang-mono committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ce6e2c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Enable g_fopen to have the capability of handling opening files with … 

    …unicode name on all platforms
    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    b44c803 View commit details
    Browse the repository at this point in the history

  2. Add comment

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    159e7a1 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    dccc8bb View commit details
    Browse the repository at this point in the history

  4. Fix file indentation format

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6ff2c63 View commit details
    Browse the repository at this point in the history

  5. Check if string contains non-ascii char

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ab352d4 View commit details
    Browse the repository at this point in the history

  6. Remove unused callback

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ed07899 View commit details
    Browse the repository at this point in the history

  7. Remove redundant comment

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    98ad004 View commit details
    Browse the repository at this point in the history

  8. Update method name

    @fanyang-mono
    fanyang-mono committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    91edfdd View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Fixed some method not found issues and remove the optimization for g_… 

    …fopen
    @fanyang-mono
    fanyang-mono committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    561dd40 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Fix tailcall

    @fanyang-mono
    fanyang-mono committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    43aa032 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Disable tailcall optimization when calling a trimmed method

    @fanyang-mono
    fanyang-mono committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a4d901f View commit details
    Browse the repository at this point in the history

  2. Free method header

    @fanyang-mono
    fanyang-mono committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a6f5bc2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Fix windows build error

    @fanyang-mono
    fanyang-mono committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b964fc4 View commit details
    Browse the repository at this point in the history

  2. Free method header at the correct locatioin

    @fanyang-mono
    fanyang-mono committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    488676a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Fix the condition of skipping tailcall

    @fanyang-mono
    fanyang-mono committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b3b03f5 View commit details
    Browse the repository at this point in the history

  2. Fix test failure

    @fanyang-mono
    fanyang-mono committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e22b851 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Move JIT/AOT call invoke away from MINT_CALL, as it is not needed there.

    @fanyang-mono
    fanyang-mono committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9964c82 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Fix virtual tail call

    @fanyang-mono
    fanyang-mono committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9bdceb1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into enable_il_trim_wasm_a… 

    …lways
    @fanyang-mono
    fanyang-mono committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bf31655 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into enable_il_trim_wasm_always

    @fanyang-mono
    fanyang-mono authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    92773d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Address review feedback

    @fanyang-mono
    fanyang-mono committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a6fa8c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into enable_il_trim_wasm_always

    @fanyang-mono
    fanyang-mono committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    97ee332 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Put the trimmed assemblies in a new folder, output an updated list of… 

    … assemblies and update _WasmAssembliesInternal with the new list
    @fanyang-mono
    fanyang-mono committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f5860d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Put trimmed assemblies in IntermediateOutputPath

    @fanyang-mono
    fanyang-mono committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    523bd20 View commit details
    Browse the repository at this point in the history

  2. Remove TrimmedAssemblies

    @fanyang-mono
    fanyang-mono committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a39f0ee View commit details
    Browse the repository at this point in the history

  3. Create trimmed assembly folder before the parallel run

    @fanyang-mono
    fanyang-mono committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1ee9c57 View commit details
    Browse the repository at this point in the history

  4. Try to fix the issue with missing item

    @fanyang-mono
    fanyang-mono committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    872c2ca View commit details
    Browse the repository at this point in the history

  5. Fix parallelism issue

    @fanyang-mono
    fanyang-mono committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e51edf7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into enable_il_trim_wasm_always

    @fanyang-mono
    fanyang-mono committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b6fa669 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Only start the trim when the assembly is newer than the output

    @fanyang-mono
    fanyang-mono committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d6cb0ac View commit details
    Browse the repository at this point in the history

  2. Add assembly item to the list, when

    @fanyang-mono
    fanyang-mono committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2687449 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Add some logging

    @fanyang-mono
    fanyang-mono committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    a133e9d View commit details
    Browse the repository at this point in the history

  2. Fixed runtimeconfig.json file path issue and disabed failed tests

    @fanyang-mono
    fanyang-mono committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ae5c260 View commit details
    Browse the repository at this point in the history

  3. Update parameter name

    @fanyang-mono
    fanyang-mono committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    58ec329 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Fix wasi build

    @fanyang-mono
    fanyang-mono committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    288e186 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Use the correct parameter

    @fanyang-mono
    fanyang-mono committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    482ce8f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into enable_il_trim_wasm_always

    @fanyang-mono
    fanyang-mono authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    725dbfd View commit details
    Browse the repository at this point in the history

  3. Fix runtime test failure

    @fanyang-mono
    fanyang-mono committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    11929f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge remote-tracking branch 'origin/main' into enable_il_trim_wasm_a… 

    …lways
    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    968da46 View commit details
    Browse the repository at this point in the history

  2. WasmAppBuilder: runtimeconfig.json path can be null

    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a064c3a View commit details
    Browse the repository at this point in the history

  3. cleanup

    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    117e6b3 View commit details
    Browse the repository at this point in the history

  4. ILStrip: fix typo in id name

    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b15ef5b View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    cb975b8 View commit details
    Browse the repository at this point in the history

  6. ILStrip: ensure output assemblies are in the same order as the input.… 

    … This is required for incremental builds.
    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1743fb9 View commit details
    Browse the repository at this point in the history

  7. more cleanup

    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    4919f5a View commit details
    Browse the repository at this point in the history

  8. Re-enable disabled tests

    @radical
    radical committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    f9d07b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Change the default value for WasmStripILAfterAOT to false

    @fanyang-mono
    fanyang-mono committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9de167c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Fix the issue with changing the value of WasmStripILAfterAOT between … 

    …incremental builds
    @fanyang-mono
    fanyang-mono committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1c9e04d View commit details
    Browse the repository at this point in the history

  2. Move the location of file deleting

    @fanyang-mono
    fanyang-mono committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7764b25 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Use WasmAssembliesFinal or ResolvedFileToPublish during publish in Wa… 

    …smSDK
    @maraf
    maraf committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    21a066a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Copy metadata in AOT compiler and when creating WasmAssembliesToBundl… 

    …e from ResolvedFileToPublish
    @maraf
    maraf committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    aeab3ce View commit details
    Browse the repository at this point in the history

  2. Add _WasmSatelliteAssemblies to WasmAssembliesFinal

    @maraf
    maraf committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e117b79 View commit details
    Browse the repository at this point in the history

  3. Add a wasm template test

    @fanyang-mono
    fanyang-mono committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3f630a1 View commit details
    Browse the repository at this point in the history

  4. Include all non-dll ResolvedFileToPublish for ComputeWasmPublishAssets

    @maraf
    maraf committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    12cff3d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Merge remote-tracking branch 'upstream/main' into fan/enable_il_trim_… 

    …wasm_always

# Conflicts:
#	src/mono/wasm/Wasm.Build.Tests/WasmTemplateTestBase.cs
    @maraf
    maraf committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    17085d9 View commit details
    Browse the repository at this point in the history

  2. Add a blazor template test

    @fanyang-mono
    fanyang-mono committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ed84935 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Address review feedback

    @fanyang-mono
    fanyang-mono committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f2011f8 View commit details
    Browse the repository at this point in the history

  2. Update src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs 

    Co-authored-by: Ankit Jain <[email protected]>
    @fanyang-mono @radical
    fanyang-mono and radical authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    88d537b View commit details
    Browse the repository at this point in the history

  3. Update parameter name

    @fanyang-mono
    fanyang-mono committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c4c3155 View commit details
    Browse the repository at this point in the history

  4. Update usage of parameter

    @fanyang-mono
    fanyang-mono committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    00b1f21 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Revert EmccCompile change

    @fanyang-mono
    fanyang-mono committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7b76c7e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into enable_il_trim_wasm_a… 

    …lways
    @radical
    radical committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    977f49d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. MonoAOTCompiler: revert rebuilding when WasmStripILAfterAOT value cha… 

    …nges
    @radical
    radical committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ada4f8b View commit details
    Browse the repository at this point in the history

  2. Compress -> GZipCompress, and cleanup

    @radical
    radical committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4557eb4 View commit details
    Browse the repository at this point in the history

  3. rework the tests 

    - to support webcil case
- run blazor app
- add cases for the default setting, and the opposite
- cleanup
    @radical
    radical committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9a7c37d View commit details
    Browse the repository at this point in the history

  4. ILStrip.cs: Emit a message about stripping to make it obvious to the … 

    …user
    @radical
    radical committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    562d845 View commit details
    Browse the repository at this point in the history

  5. WasmApp.targets: update comment

    @radical
    radical committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    740bb45 View commit details
    Browse the repository at this point in the history

  6. Change default value to false and update test

    @fanyang-mono
    fanyang-mono committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    a93b5d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge remote-tracking branch 'origin/main' into enable_il_trim_wasm_a… 

    …lways
    @fanyang-mono
    fanyang-mono committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    5fc92ca View commit details
    Browse the repository at this point in the history