Add EnableDiagnostics sub-configs for IPC, debugger, and profiler #90159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @tommcdon Issue DetailsToday we have one config knob for enabling/disabling all of diagnostics. This PR adds additional granular diagnostic environment variables for the Diagnostics IPC channel, Debugger, and Profiler. This can be useful in production scenarios where fine grain control might be needed to disable creation of the debugger IPC vs. debugger pipes. This came up in a discussion in #86259 (comment).
|
mikem8361
approved these changes
Aug 8, 2023
hoyosjs
approved these changes
Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have one config knob for enabling/disabling all of diagnostics. This PR adds additional granular diagnostic environment variables for the Diagnostics IPC channel, Debugger, and Profiler. This can be useful in production scenarios where fine grain control might be needed to disable creation of the debugger IPC vs. debugger pipes. This came up in a discussion in #86259 (comment).