Improve test failure messages #89967
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
added
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsI've noticed that there are more coding error scenarios where a test will fail and the failure that is hit is the failed to resolve "test.exe" error. I don't fully have my head around which exceptions are being caught and logged but it seems like a lot more than there used to be. Suffice it to say, when the only output from a test failure is about failing to resolve test.exe, that isn't particularly helpful when what actually happened is you had a mistake in your code and an exception was thrown. With the linker now eating more exceptions and returning a non-zero exit code rather than throwing and crashing I think it's worth having the test framework fail with the messages from the linker if the exit code is non-zero. For the tests that expect a non zero exit code, I added
|
marek-safar
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsI've noticed that there are more coding error scenarios where a test will fail and the failure that is hit is the failed to resolve "test.exe" error. I don't fully have my head around which exceptions are being caught and logged but it seems like a lot more than there used to be. Suffice it to say, when the only output from a test failure is about failing to resolve test.exe, that isn't particularly helpful when what actually happened is you had a mistake in your code and an exception was thrown. With the linker now eating more exceptions and returning a non-zero exit code rather than throwing and crashing I think it's worth having the test framework fail with the messages from the linker if the exit code is non-zero. For the tests that expect a non zero exit code, I added
|
marek-safar
removed
linkable-framework
ghost
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsI've noticed that there are more coding error scenarios where a test will fail and the failure that is hit is the failed to resolve "test.exe" error. I don't fully have my head around which exceptions are being caught and logged but it seems like a lot more than there used to be. Suffice it to say, when the only output from a test failure is about failing to resolve test.exe, that isn't particularly helpful when what actually happened is you had a mistake in your code and an exception was thrown. With the linker now eating more exceptions and returning a non-zero exit code rather than throwing and crashing I think it's worth having the test framework fail with the messages from the linker if the exit code is non-zero. For the tests that expect a non zero exit code, I added
|
mrvoorhe
force-pushed
the
linker-improve-failure-message
branch
from
0c25bd7
to
20eb69c
Compare
I've noticed that there are more coding error scenarios where a test will fail and the failure that is hit is the failed to resolve "test.exe" error. I don't fully have my head around which exceptions are being caught and logged but it seems like a lot more than there used to be. Suffice it to say, when the only output from a test failure is about failing to resolve test.exe, that isn't particularly helpful when what actually happened is you had a mistake in your code and an exception was thrown. With the linker now eating more exceptions and returning a non-zero exit code rather than throwing and crashing I think it's worth having the test framework fail with the messages from the linker if the exit code is non-zero. For the tests that expect a non zero exit code, I added `ExpectNonZeroExitCodeAttribute`. Currently there is only 1 test that needs this.
mrvoorhe
force-pushed
the
linker-improve-failure-message
branch
from
20eb69c
to
90d4b6f
Compare
ghost
locked as resolved and limited conversation to collaborators
I've noticed that there are more coding error scenarios where a test will fail and the failure that is hit is the failed to resolve "test.exe" error. I don't fully have my head around which exceptions are being caught and logged but it seems like a lot more than there used to be.
Suffice it to say, when the only output from a test failure is about failing to resolve test.exe, that isn't particularly helpful when what actually happened is you had a mistake in your code and an exception was thrown.
With the linker now eating more exceptions and returning a non-zero exit code rather than throwing and crashing I think it's worth having the test framework fail with the messages from the linker if the exit code is non-zero.
For the tests that expect a non zero exit code, I added
ExpectNonZeroExitCodeAttribute.