Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Set method context for delegate GDV #89499

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Jul 26, 2023

Instead of passing through the IL context, update the context to be the exact method that was recorded in the delegate (which will include the full instantiation).

Also do a bit of clean up.

Fix #89495

Instead of passing through the IL context, update the method context to
be the exact method that were recorded in the delegate (which will
include the full instantiation).

Also do a bit of clean up.

Fix dotnet#89495
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 26, 2023
@ghost ghost assigned jakobbotsch Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead of passing through the IL context, update the method context to be the exact method that were recorded in the delegate (which will include the full instantiation).

Also do a bit of clean up.

Fix #89495

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr pgo, runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if there are no new crashes on CI/extra-platform

@jakobbotsch jakobbotsch marked this pull request as ready for review July 26, 2023 19:25
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @EgorBo @AndyAyersMS

Runtime test failure is known according to build analysis. I'm not sure about runtime-extra-platforms -- build analysis doesn't seem to find anything, but it seems very red, so very hard for me to have much confidence.
runtime-coreclr pgo was green.

@jakobbotsch jakobbotsch requested a review from AndyAyersMS July 26, 2023 19:27
@jakobbotsch
Copy link
Member Author

Going to kick off pgostress as well for some more testing.

@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr pgostress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

The pgostress failures are #88507, #88586, #83658.

@jakobbotsch jakobbotsch merged commit b9c6d68 into dotnet:main Jul 27, 2023
@jakobbotsch jakobbotsch deleted the gdv-exact-context-delegate branch July 27, 2023 08:48
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: GDV does not handle delegates pointing to generic methods correctly
3 participants