-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Set method context for delegate GDV #89499
JIT: Set method context for delegate GDV #89499
Conversation
Instead of passing through the IL context, update the method context to be the exact method that were recorded in the delegate (which will include the full instantiation). Also do a bit of clean up. Fix dotnet#89495
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsInstead of passing through the IL context, update the method context to be the exact method that were recorded in the delegate (which will include the full instantiation). Also do a bit of clean up. Fix #89495
|
/azp run runtime-coreclr pgo, runtime-extra-platforms |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if there are no new crashes on CI/extra-platform
cc @dotnet/jit-contrib PTAL @EgorBo @AndyAyersMS Runtime test failure is known according to build analysis. I'm not sure about runtime-extra-platforms -- build analysis doesn't seem to find anything, but it seems very red, so very hard for me to have much confidence. |
Going to kick off pgostress as well for some more testing. |
/azp run runtime-coreclr pgostress |
Azure Pipelines successfully started running 1 pipeline(s). |
Instead of passing through the IL context, update the context to be the exact method that was recorded in the delegate (which will include the full instantiation).
Also do a bit of clean up.
Fix #89495