Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter list of candidate invocations for parsing in binding generator #89226

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Jul 20, 2023

Improves generator perf tracing metrics on the Roslyn repo recorded by GeneratorTracer. Average time spent in the generator goes from ~2s to ~145ms. See https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Contributes to #83534. Next steps would be to

@layomia layomia added this to the 8.0.0 milestone Jul 20, 2023
@layomia layomia self-assigned this Jul 20, 2023
@ghost
Copy link

ghost commented Jul 20, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Improves generator perf tracing metrics recorded by GeneratorTracer. See https://gist.github.com/layomia/8f51ac107f76853f4f37a6a7c596f67e.

Contributes to #83534. Next steps would be to

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration

Milestone: 8.0.0

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@layomia layomia merged commit 1db167c into dotnet:main Jul 20, 2023
@layomia
Copy link
Contributor Author

layomia commented Jul 20, 2023

/backport to release/8.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/8.0-preview7: https://github.com/dotnet/runtime/actions/runs/5614162921

@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants