-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Integrate DevServer into WasmAppHost #88985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
WebAssembly architecture
area-Host
os-browser
Browser variant of arch-wasm
labels
Jul 17, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsTBD
|
maraf
commented
Jul 21, 2023
49 tasks
radical
reviewed
Jul 24, 2023
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Outdated
Show resolved
Hide resolved
radical
reviewed
Jul 24, 2023
radical
reviewed
Jul 24, 2023
radical
reviewed
Jul 24, 2023
radical
reviewed
Jul 24, 2023
radical
reviewed
Jul 24, 2023
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Outdated
Show resolved
Hide resolved
radical
reviewed
Jul 24, 2023
src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SatelliteLoadingTests.cs
Show resolved
Hide resolved
radical
reviewed
Jul 24, 2023
radical
reviewed
Jul 24, 2023
radical
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
…untimeConfigurationFiles=true from tests
3 tasks
radical
reviewed
Jul 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentsWebAssemblyApplicationBuilderExtensions.cs
ContentEncodingNegotiator.cs
WebAssemblyNetDebugProxyAppBuilderExtensions.cs
DevServer.cs
is mix betweenWebServer
and asptnetcore DevServer/Program.csDevServerStartup.cs
mix betweenWebServerStartup
and asptnetcore DevServer/Startup.csDevServerOptions.cs
is inspired byWebServerOptions
DebugProxyLauncher.cs
changed folder where it expects debug proxyHTMLPath
optionalBrowser.targets
because that is the topmost place whereOutputPath
is correctly set. Unfortunatelly it's after the default run parameters are set. So it must override it_WebAssemblyUserRunParameters
to preserve user defined values. The property will be set in SDK dotnet/sdk@569f220UsingMicrosoftNETSdkBlazorWebAssembly
is removed from Wasm SDKUntil resolved, TestAppScenarios pass
GenerateRuntimeConfigurationFiles=true
as command line argument to override Microsoft.NET.Sdk.WebAssembly.Browser.targets#L64GenerateRuntimeConfigurationFiles=false
from Wasm SDK, since the WasmAppHost needs it and Blazor SDK MoveGenerateRuntimeConfigurationFiles=false
back to Blazor SDK from Wasm SDK sdk#34177 change already flown to installerContributes to #70762