[browser][MT] Make HTTP and WS clients work #87567

pavelsavara · 2023-06-14T17:57:01Z

BrowserWebSocket

_thisLock for locking the state for MT access
use FEATURE_WASM_THREADS to conditionaly wrap the calls with SynchronizationContext.Send for all calls to JS
split ConnectAsyncCore and CreateCore to separate methods. CreateCore is synchronous and creates the JS proxy. The other one needs to be executed separately, so that Abort() before await ConnectAsync() works as expected. Yielding to main loop.

BrowserHttpHandler

WasmFetchResponse.ThisLock for locking the state for MT access
use FEATURE_WASM_THREADS to conditionaly wrap the calls with SynchronizationContext.Send for all calls to JS

Other

make JSSynchronizationContext possible to install on multiple threads
private draft of SynchronizationContextExtension hidden from API by CompatibilitySuppressions.xml
- these are sync and async helpers for dispatching call to correct thread and propagating result and exception back
private draft of JSHost.CurrentOrMainJSSynchronizationContext
- this allows to use main thread as fallback for JS interop, if there is no JSSynchronizationContext installed on current thread
private draft of JSObject.SynchronizationContext
- this allows to dispatch call back to correct thread for the proxy
private draft of WebWorker hidden from API by CompatibilitySuppressions.xml
JSException from another thread doesn't have thread affinity and stack trace.
more thread affinity asserts

Contributes to #85592

ghost · 2023-06-14T17:57:14Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Ideas:

both HTTP and WS clients support only async APIs for long operations, including via Streams.
async operations are easy to schedule onto thread with JSSynchronizationContext installed
when you create HTTP or WS client on thread pool, your call would be dispatched to main thread instead.
the client would remember it's origin and dispatch subsequent calls to the correct thread/worker

Other

added SendAsync SendAsync<T> and Post<T> helpers which dispatching to SynchronizationContext and waiting for result.

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	8.0.0

lambdageek

The only thing I'd be careful about is assuming that the only synchronization contexts that can be installed on a thread is either nothing or JSSynchronizationContext.

Also I'm not sure there's any good way to avoid a ton of allocation with the SynchronizationContextExtension methods, but using static lambdas that don't capture local variables or fields of this and instead passing extra arguments can decrease some of the allocations. (of course the call to the actual SynchronizationContext.Post(SendOrPostCallback callback, object? state) method will still need to allocate something - either a state object or a closure. but maybe some of the other allocations can be avoided by carefully constructing the code)

src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj

...System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs

pavelsavara · 2023-06-21T14:09:02Z

/azp run runtime-wasm

azure-pipelines · 2023-06-21T14:09:11Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-06-22T13:54:37Z

/azp run runtime-wasm

azure-pipelines · 2023-06-22T13:54:49Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-06-22T15:27:53Z

/azp run runtime-wasm

azure-pipelines · 2023-06-22T15:28:02Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-06-22T17:21:41Z

/azp run runtime-wasm

azure-pipelines · 2023-06-22T17:21:50Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2023-06-23T12:27:20Z

src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs

+#if FEATURE_WASM_THREADS
+                if (!abortController.IsDisposed)
+                {
+                    abortController.SynchronizationContext.Send(static (JSObject _abortController) =>
+                    {
+                        BrowserHttpInterop.AbortRequest(_abortController);
+                        _abortController.Dispose();
+                    }, abortController);
+                }
+#else
                if (!abortController.IsDisposed)
                {
                    BrowserHttpInterop.AbortRequest(abortController);
+                    abortController.Dispose();
                }
-                abortController.Dispose();
+#endif


This should be valid

Suggested change

#if FEATURE_WASM_THREADS

if (!abortController.IsDisposed)

{

abortController.SynchronizationContext.Send(static (JSObject _abortController) =>

{

BrowserHttpInterop.AbortRequest(_abortController);

_abortController.Dispose();

}, abortController);

}

#else

if (!abortController.IsDisposed)

{

BrowserHttpInterop.AbortRequest(abortController);

abortController.Dispose();

}

abortController.Dispose();

#endif

if (!abortController.IsDisposed)

{

#if FEATURE_WASM_THREADS

abortController.SynchronizationContext.Send(static (JSObject abortController) =>

{

#else

BrowserHttpInterop.AbortRequest(abortController);

abortController.Dispose();

#if FEATURE_WASM_THREADS

}, abortController);

#endif

}

Are you saying that I should shadow abortController name in the callback, so that I could have more DRY code ?

We can further tweak it in follow-up PRs. I will merge it so that it has time to flow to Blazor over the weekend.

lambdageek

On the surface LGTM. I'm not super-familiar with the the implementations of these streams, though.

...untime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/WebWorker.cs

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Jun 14, 2023

pavelsavara added this to the 8.0.0 milestone Jun 14, 2023

pavelsavara requested a review from lambdageek June 14, 2023 17:57

pavelsavara self-assigned this Jun 14, 2023

This comment was marked as spam.

Sign in to view

This was referenced Jun 14, 2023

WasmTemplateTests.ConsolePublishAndRun fails with exit code 137 #87414

Closed

Tests.System.TimeProviderTests.TestProviderTimer test failure #87477

Closed

lambdageek reviewed Jun 15, 2023

View reviewed changes

pavelsavara force-pushed the browser_dispatch_to_web_worker branch from 1ea5b74 to 1bc02d2 Compare June 19, 2023 17:21

This was referenced Jun 19, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

Tracking issue for CI build timeouts #76454

Closed

pavelsavara force-pushed the browser_dispatch_to_web_worker branch 2 times, most recently from 5a0c246 to 5877eda Compare June 21, 2023 14:01

build-analysis bot mentioned this pull request Jun 21, 2023

System.Text.Json failing some large file tests #59678

Closed

wip

5799250

pavelsavara force-pushed the browser_dispatch_to_web_worker branch from 58a07bf to 5799250 Compare June 22, 2023 11:39

fix

b5e7134

pavelsavara added 2 commits June 22, 2023 17:06

fix

6422823

fix

751db32

pavelsavara added 2 commits June 22, 2023 19:04

fix

6c673ca

fix

673214c

build-analysis bot mentioned this pull request Jun 22, 2023

Work item tests crash on OSX x64 Debug #87287

Closed

pavelsavara marked this pull request as ready for review June 22, 2023 20:17

pavelsavara requested review from lewing, radical and kg as code owners June 22, 2023 20:17

pavelsavara requested review from maraf and lambdageek June 22, 2023 20:19

maraf reviewed Jun 23, 2023

View reviewed changes

lambdageek reviewed Jun 23, 2023

View reviewed changes

...untime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/WebWorker.cs Show resolved Hide resolved

pavelsavara mentioned this pull request Jun 20, 2023

[browser][MT] Blazor E2E test with MT runtime dotnet/aspnetcore#48925

Closed

lambdageek approved these changes Jun 23, 2023

View reviewed changes

pavelsavara mentioned this pull request Jun 23, 2023

[browser][MT] Multithreading and JavaScript async interop in .NET 9 #85592

Closed

31 tasks

pavelsavara merged commit 574ad01 into dotnet:main Jun 23, 2023

fMichaleczek mentioned this pull request Jul 17, 2023

Avalonia Browser is broken on net8.0 (Emscripten 3.1.34) AvaloniaUI/Avalonia#12225

Closed

ericstj mentioned this pull request Jul 19, 2023

Unnecessary suppression errors showing up in build using .NET 8 Preview 7 SDK #89206

Closed

ghost locked as resolved and limited conversation to collaborators Jul 23, 2023

pavelsavara deleted the browser_dispatch_to_web_worker branch September 2, 2024 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[browser][MT] Make HTTP and WS clients work #87567

[browser][MT] Make HTTP and WS clients work #87567

pavelsavara commented Jun 14, 2023 •

edited

Loading

ghost commented Jun 14, 2023

This comment was marked as spam.

lambdageek left a comment

pavelsavara commented Jun 21, 2023

azure-pipelines bot commented Jun 21, 2023

pavelsavara commented Jun 22, 2023

azure-pipelines bot commented Jun 22, 2023

pavelsavara commented Jun 22, 2023

azure-pipelines bot commented Jun 22, 2023

pavelsavara commented Jun 22, 2023

azure-pipelines bot commented Jun 22, 2023

maraf Jun 23, 2023

pavelsavara Jun 23, 2023

pavelsavara Jun 23, 2023

lambdageek left a comment

[browser][MT] Make HTTP and WS clients work #87567

[browser][MT] Make HTTP and WS clients work #87567

Conversation

pavelsavara commented Jun 14, 2023 • edited Loading

BrowserWebSocket

BrowserHttpHandler

Other

ghost commented Jun 14, 2023

This comment was marked as spam.

lambdageek left a comment

Choose a reason for hiding this comment

pavelsavara commented Jun 21, 2023

azure-pipelines bot commented Jun 21, 2023

pavelsavara commented Jun 22, 2023

azure-pipelines bot commented Jun 22, 2023

pavelsavara commented Jun 22, 2023

azure-pipelines bot commented Jun 22, 2023

pavelsavara commented Jun 22, 2023

azure-pipelines bot commented Jun 22, 2023

maraf Jun 23, 2023

Choose a reason for hiding this comment

pavelsavara Jun 23, 2023

Choose a reason for hiding this comment

pavelsavara Jun 23, 2023

Choose a reason for hiding this comment

lambdageek left a comment

Choose a reason for hiding this comment

pavelsavara commented Jun 14, 2023 •

edited

Loading