-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure JsonSerializerOptions always returns a JsonTypeInfo for object
.
#87093
Merged
eiriktsarpalis
merged 2 commits into
dotnet:main
from
eiriktsarpalis:always-return-obj-typeinfo
Jun 5, 2023
Merged
Ensure JsonSerializerOptions always returns a JsonTypeInfo for object
.
#87093
eiriktsarpalis
merged 2 commits into
dotnet:main
from
eiriktsarpalis:always-return-obj-typeinfo
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #87073.
|
This was referenced Jun 3, 2023
eerhardt
reviewed
Jun 4, 2023
...ies/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectConverter.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Jun 5, 2023
...System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs
Show resolved
Hide resolved
krwq
approved these changes
Jun 5, 2023
eerhardt
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 7, 2023
dotnet-maestro bot
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 8, 2023
[main] Update dependencies from dotnet/efcore dotnet/runtime - Fix Http Results test to respond to dotnet/runtime#87093 - Convert to new generic JsonStringEnumConverter<TEnum> to fix JSON source generator warning. InteractionType is used in a JsonSerializerContext. With dotnet/runtime#87224, there is now a warning to convert source generated usages of JsonStringEnumConverter to JsonStringEnumConverter<TEnum>. I went ahead and updated the other 2 usages as well, to make them consistent. - Skip AcceptAsync_NoCertificateCallback_RemovedFromPendingConnections See #48678
ghost
locked as resolved and limited conversation to collaborators
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87073.