[mono] Exclude unused bundle files in AppleAppBuilder #86316
Conversation
|
@kotlarmilos - how do you determine they are un-used? |
The runtime loads the AOT module of a container assembly using the assembly name (#83711), so the actual assembly is not required. As for the globalization files, the HelloiOS sample app should use I have checked the HelloiOS sample app locally, but can't confirm that other globalization files are never used. @akoeplinger is it safe to remove |
Yes, it is. |
|
/cc: @akoeplinger @ivanpovazan |
src/mono/sample/iOS/Program.csproj
Outdated
| @@ -109,6 +109,7 @@ | |||
| EnableAppSandbox="$(EnableAppSandbox)" | |||
| DiagnosticPorts="$(DiagnosticPorts)" | |||
| StripSymbolTable="$(StripDebugSymbols)" | |||
| ExcludeFromAppDir="$(_iOSLikeDedupAssembly)" | |||
There was a problem hiding this comment.
nit: This is really a nit but it would be cleaner to introduce a new local Item say:
_ExcludeFromAppDir Include="$(_iOSLikeDedupAssembly)"around lines 60-65 above
and then have the full list passed to the AppleAppBuilderTask:
ExcludeFromAppDir="@(_ExcludeFromAppDir)"
This way it would be simpler to expand the list of excluded items - if we figure out in the future something else should be excluded.
Otherwise, LGTM!
There was a problem hiding this comment.
Agreed. I think we could do the same thing to more properties and simplify the appbuilder.
There was a problem hiding this comment.
Thanks.
I think we could do the same thing to more properties and simplify the appbuilder.
I suggest we remove redundant properties and simplify the appbuilder in #86578.
There was a problem hiding this comment.
Thanks.
I think we could do the same thing to more properties and simplify the appbuilder.
I suggest we remove redundant properties and simplify the appbuilder in #86578.
Agreed!
ghost
locked as resolved and limited conversation to collaborators
This PR aims to reduce the bundle size of the HelloiOS app by excluding unused globalization files and the dedup assembly. These files are currently included in the performance measurements but are not actually used by the app.
Here is an example with the unused bundle files included.
SOD - iOS HelloWorld .app Size