[release/8.0-preview4] [mono] Add back OP_XOP_OVR_X_X for arm64 #85409
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
And also add missing intrinsic attributes. This addresses feedback from #85390
dotnet-issue-labeler
bot
added
the
needs-area-label
|
@carlossanlop do we need tactics approval for preview branches? |
lewing
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #85401 to release/8.0-preview4 /cc @lewing @radekdoulik Customer ImpactThe bug affects System.Buffers.IndexOfAnyAsciiSearcher.IndexOfAnyVectorized and possibly more BCL methods, which use intrinsics with OP_XOP_OVR_X_X on mono/arm64. Testing@akoeplinger confirmed it fixes the issue. #85401 (comment) and also CI tests don't fail anymore RiskLow, the mechanism of the issue was discussed in chat and is known. The fix is simple. IMPORTANT: If this backport is for a servicing release, please verify that:
|
lewing
added
Servicing-consider
yes |
rbhanda
added
Servicing-approved
|
@akoeplinger @lewing is this ready to merge? |
|
yes |
ghost
locked as resolved and limited conversation to collaborators
Backport of #85401 to release/8.0-preview4
/cc @lewing @radekdoulik
Customer Impact
The bug affects System.Buffers.IndexOfAnyAsciiSearcher.IndexOfAnyVectorized and possibly more BCL methods, which use intrinsics with OP_XOP_OVR_X_X on mono/arm64.
Testing
@akoeplinger confirmed it fixes the issue. #85401 (comment) and also CI tests don't fail anymore
Risk
Low, the mechanism of the issue was discussed in chat and is known. The fix is simple.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.