Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Invoke AssemblyLoad hooks from RuntimeAssemblyBuilder:.ctor ()… #85307

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Apr 25, 2023

… instead from native code.

The call from native code is made before the manifest module was created, causing errors if the hook tried to access Assembly.ManifestModule.

Fixes #84771.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2023
@ghost ghost assigned vargaz Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

… instead from native code.

The call from native code is made before the manifest module was created, causing errors if the hook tried to access Assembly.ManifestModule.

Fixes #84771.

Author: vargaz
Assignees: vargaz
Labels:

area-AssemblyLoader-mono, needs-area-label

Milestone: -

@marek-safar marek-safar removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2023
… instead from native code.

The call from native code is made before the manifest module was created, causing errors if the
hook tried to access Assembly.ManifestModule.

Fixes dotnet#84771.
@vargaz vargaz removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 28, 2023
@vargaz vargaz merged commit 5cea3d6 into dotnet:main Apr 28, 2023
@vargaz vargaz deleted the sre-onload branch April 28, 2023 16:22
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HelloWorld console app build failed on ppc64le with .NET8 Preview3
3 participants