Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Move some BasicBlock methods into block.cpp #85224

Merged
merged 2 commits into from
Apr 24, 2023
Merged

JIT: Move some BasicBlock methods into block.cpp #85224

merged 2 commits into from
Apr 24, 2023

Conversation

AndyAyersMS
Copy link
Member

Collect up a few BasicBlock methods that were scattered about in other files.

@AndyAyersMS
JIT: Move some BasicBlock methods into block.cpp
ff324ba 
Collect up a few `BasicBlock` methods that were scattered about in other files.
@ghost ghost assigned AndyAyersMS Apr 23, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 23, 2023
@ghost
Copy link

ghost commented Apr 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Collect up a few BasicBlock methods that were scattered about in other files.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS
Copy link
Member Author

@BruceForstall PTAL
cc @dotnet/jit-contrib

BruceForstall
BruceForstall approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like formatting needs to be fixed. Apparently you hit some kind of Azure Storage glitch with replay/asmdiffs

@AndyAyersMS AndyAyersMS merged commit 6e23db2 into dotnet:main Apr 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyAyersMS @jakobbotsch @BruceForstall