Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][wasm][aot] Prevent llvm from optimizing away stack stores of valuetypes containing object references when they are returned from a method as a scalar. #85152

Merged
merged 1 commit into from
Apr 22, 2023
Merged

[mono][wasm][aot] Prevent llvm from optimizing away stack stores of valuetypes containing object references when they are returned from a method as a scalar. #85152

merged 1 commit into from
Apr 22, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Apr 21, 2023

No description provided.

@ghost ghost assigned vargaz Apr 21, 2023
@vargaz vargaz changed the title Wasm llvm gc [mono][wasm][aot] Prevent llvm from optimizing away stack stores of valuestypes containing object references when they are returned from a method as a scalar. Apr 21, 2023
@vargaz vargaz changed the title [mono][wasm][aot] Prevent llvm from optimizing away stack stores of valuestypes containing object references when they are returned from a method as a scalar. [mono][wasm][aot] Prevent llvm from optimizing away stack stores of valuetypes containing object references when they are returned from a method as a scalar. Apr 21, 2023
@vargaz
[mono][wasm][aot] Prevent llvm from optimizing away stack stores of v…
4c45365 
…aluetypes containing object references when they are returned from a method as a scalar.

Fixes dotnet#85012.
@vargaz
Copy link
Contributor Author

vargaz commented Apr 21, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 21, 2023
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Apr 22, 2023

Fixes
#85012

@vargaz
Copy link
Contributor Author

vargaz commented Apr 22, 2023

Failures look unrelated.

@vargaz vargaz merged commit c7aadc0 into dotnet:main Apr 22, 2023
@vargaz vargaz deleted the wasm-llvm-gc branch April 22, 2023 00:42
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@lewing lewing lewing approved these changes

@radical radical Awaiting requested review from radical

Assignees

@vargaz vargaz

Labels
area-Codegen-LLVM-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vargaz @lewing @lambdageek