Sync shared code from aspnetcore #85149
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943
|
|
@amcasey FYI, changes to shared source in aspnetcore needs to be mirrored here. It's easy with https://github.com/dotnet/runtime/actions/workflows/aspnetcore-sync.yml |
|
@JamesNK Does that GH action need to be run manually? I was expecting it to happen automatically. In any case, sorry for the inconvenience. |
|
Syncing from runtime to aspnetcore is automatic because we assume most updates happen in runtime. Syncing from aspnetcore to runtime is manual for when we update aspnetcore first. The actions only compare the diff, they don't know which version is 'right'. |
Guess I get to make another doc update. 😆 |
...to clarify that dotnet->aspnetcore is automatic but aspnetcore->dotnet is manual. Prompted by dotnet#85149
...to clarify that dotnet->aspnetcore is automatic but aspnetcore->dotnet is manual. Prompted by #85149
ghost
locked as resolved and limited conversation to collaborators
This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943