-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Move mono.mscordbi subset off the offical build #84938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveisok
changed the title
[release/7.0] Move mono.mscordbi subset off the offical buildMove mono.mscordbi subset off the offical build
[release/7.0] Move mono.mscordbi subset off the offical build
Apr 17, 2023
@carlossanlop this is a tell mode change. |
hoyosjs
approved these changes
Apr 17, 2023
@carlossanlop @mmitche indicated he would like this in may servicing, so it needs promoted to release/7.0 as well. |
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/7.0. Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed. |
…o.mscordbi subset off the offical build Backport of dotnet#81917 This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
carlossanlop
force-pushed
the
move-mscordbi-70
branch
from
April 17, 2023 19:24
c1225f9
to
c4dceaf
Compare
carlossanlop
approved these changes
Apr 17, 2023
thaystg
approved these changes
Apr 17, 2023
Known Build Error failed to link these issues:
|
carlossanlop
added
Servicing-approved
Approved for servicing release
and removed
Servicing-approved
Approved for servicing release
labels
Apr 17, 2023
This was referenced Apr 17, 2023
ghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.