Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonNull return false when comparing against null #842

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

henrikse55
Copy link
Contributor

I'ved modified JsonNulls comparison methods to return false when
compared against null, the matching test have also been updated
in change

Fix #820

I'ved modified JsonNulls comparison methods to return false when
compared against null, the matching test have also been updated
in change

Fix dotnet#820
@dnfclas
Copy link

dnfclas commented Dec 13, 2019

CLA assistant check
All CLA requirements met.

@ahsonkhan ahsonkhan added this to the 5.0 milestone Dec 14, 2019
@henrikse55
Copy link
Contributor Author

I do not believe the current tests which are failing are related to the changes I made as it network timeouts.

I also have a couple of questions as this is my first PR:

As it's just a timeout, should the failed tests be rerun?
When I think it's ready for review, should I tag the issuer?

@ahsonkhan

@ahsonkhan
Copy link
Member

As it's just a timeout, should the failed tests be rerun?

Yes. However, what I tend to do (and encourage) is that I do a cursory search of the test failure/exception in the repo to see if an issue already exists tracking the intermittent failure, and if not, then file one, so that it gets tracked and resolved. Here are some examples: https://github.com/dotnet/corefx/issues/42583, https://github.com/dotnet/corefx/issues/42077, https://github.com/dotnet/corefx/issues/41881

When I think it's ready for review, should I tag the issuer?

Generally, you'd tag the area owners to help review the PR:
https://github.com/dotnet/runtime/blob/master/docs/area-owners.md

I am happy to look it over and provide feedback.

Copy link
Member

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating xml doc comments, looks good.

@ahsonkhan
Copy link
Member

I do not believe the current tests which are failing are related to the changes I made as it network timeouts.

Right, the test failure in CI is unrelated: https://github.com/dotnet/corefx/issues/20069#issuecomment-566292587

I have updated the xml comments to reflect the changes
that was made in JsonNull and removed left over comment
in JsonNullTests
@henrikse55
Copy link
Contributor Author

I have updated the XML docs and this should be ready for a review
@ahsonkhan @steveharter

The test failure looked unrelated to me and I've commented on #702

henrikse55 and others added 2 commits December 18, 2019 14:54
Applied the suggested change to correct xml documentation

Co-Authored-By: Ahson Khan <[email protected]>
Applied the suggested change to correct xml documentation

Co-Authored-By: Ahson Khan <[email protected]>
@ahsonkhan ahsonkhan merged commit bdfbad5 into dotnet:master Dec 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonNull should not return true when compared to null using Equals (or ==)
6 participants