Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing ValidateOptionsResultBuilder #82749

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Introducing ValidateOptionsResultBuilder #82749

merged 4 commits into from
Mar 2, 2023
+329 −3

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Feb 28, 2023

Fix #77404

@ghost ghost assigned tarekgh Feb 28, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 28, 2023

Tagging subscribers to this area: @dotnet/area-extensions-options
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #77404

Author: tarekgh
Assignees: tarekgh
Labels:

new-api-needs-documentation, area-Extensions-Options
Milestone: -

@tarekgh tarekgh added this to the 8.0.0 milestone Feb 28, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Feb 28, 2023

CC @stephentoub @geeknoid @eerhardt @layomia @eiriktsarpalis @krwq

This was referenced Feb 28, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 1, 2023
Closed
@eerhardt eerhardt mentioned this pull request Mar 1, 2023
Open
@build-analysis build-analysis bot mentioned this pull request Mar 1, 2023
Open
@build-analysis build-analysis bot mentioned this pull request Mar 2, 2023
Closed
@tarekgh
Copy link
Member Author

tarekgh commented Mar 2, 2023

The CI failure is unrelated and tracked by #82918.

@tarekgh tarekgh merged commit 57e2c3a into dotnet:main Mar 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@tarekgh tarekgh

Labels
area-Extensions-Options new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Make it easier to create quality ValidateOptionsResult instances
3 participants
@tarekgh @stephentoub @eiriktsarpalis