Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in DeniedValuesAttribute #82665

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Typo in DeniedValuesAttribute #82665

merged 2 commits into from
Feb 27, 2023

Conversation

lordfanger
Copy link
Contributor

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 25, 2023
@lordfanger
Copy link
Contributor Author

@dotnet-policy-service agree

@lordfanger
Copy link
Contributor Author

@eiriktsarpalis correct?

@build-analysis build-analysis bot mentioned this pull request Feb 25, 2023
Closed
@eiriktsarpalis
Copy link
Member

@eiriktsarpalis correct?

Better, but perhaps calling it deniedValue better reflects the name of the type?

@lordfanger
Copy link
Contributor Author

What about denied? It is from Values. What else it will be if not Value? :-D

@eiriktsarpalis
Copy link
Member

Sure denied sounds good

@ghost
Copy link

ghost commented Feb 26, 2023

Tagging subscribers to this area: @ajcvickers, @bricelam, @roji
See info in area-owners.md if you want to be subscribed.

Issue Details

#82311 (comment)

Author: lordfanger
Assignees: -
Labels:

area-System.ComponentModel.DataAnnotations, community-contribution
Milestone: -

@stephentoub stephentoub merged commit 12ca3da into dotnet:main Feb 27, 2023
@jeffhandley
Copy link
Member

@lordfanger Thanks for posting the feedback on the PR and for contributing the improvement!

@lordfanger lordfanger deleted the patch-1 branch March 19, 2023 17:58
@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.ComponentModel.DataAnnotations community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lordfanger @eiriktsarpalis @jeffhandley @stephentoub @vcsjones