Add NT_SIGINFO NOTE to ELF dumps #82449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue: #40958 |
mikem8361
force-pushed
the
nt_siginfo
branch
2 times, most recently
from
e39eebf
to
cca6386
Compare
|
@hoyosjs ping |
hoyosjs
approved these changes
Mar 5, 2023
There was a problem hiding this comment.
I don't think this is quite complete, although I am not sure if we care. System dumps also have the signal info in PRSTATUS under pr_info and potentially pr_cursig, although the last one is non-trivial for us to implement. Also, we are putting the process group in the PID field of the note. These two don't block this PR.
Linux Watson needs this to better triage ELF dumps. Add CreateDumpOptions helper struct to pass all the command options around. Add the "--code", "--errno", "--address" command line options used to fill the NT_SIGINFO NOTE. The runtime passes to createdump on a crash. Added "ExceptionType" field to "Parameters" section of the Linux crash report json.
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4348724931 |
|
@mikem8361 backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Add NT_SIGINFO NOTE to ELF dumps
Using index info to reconstruct a base tree...
M src/coreclr/debug/createdump/crashinfo.cpp
M src/coreclr/debug/createdump/crashinfo.h
M src/coreclr/debug/createdump/crashreportwriter.cpp
M src/coreclr/debug/createdump/createdump.h
M src/coreclr/debug/createdump/threadinfo.cpp
M src/coreclr/pal/src/thread/process.cpp
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/pal/src/thread/process.cpp
Auto-merging src/coreclr/debug/createdump/threadinfo.cpp
Auto-merging src/coreclr/debug/createdump/createdump.h
Auto-merging src/coreclr/debug/createdump/crashreportwriter.cpp
Auto-merging src/coreclr/debug/createdump/crashinfo.h
Auto-merging src/coreclr/debug/createdump/crashinfo.cpp
CONFLICT (content): Merge conflict in src/coreclr/debug/createdump/crashinfo.cpp
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add NT_SIGINFO NOTE to ELF dumps
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@mikem8361 an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux Watson needs this to better triage ELF dumps.
Add CreateDumpOptions helper struct to pass all the command options around. Add the "--code", "--errno", "--address" command line options used to fill the NT_SIGINFO NOTE. The runtime passes to createdump on a crash.
Added "ExceptionType" field to "Parameters" section of the Linux crash report json.