-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loop hoisting float var profitability calculation #82352
Merged
BruceForstall
merged 1 commit into
dotnet:main
from
BruceForstall:ChangeFPHoistProfitability
Feb 22, 2023
Merged
Fix loop hoisting float var profitability calculation #82352
BruceForstall
merged 1 commit into
dotnet:main
from
BruceForstall:ChangeFPHoistProfitability
Feb 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned BruceForstall
Feb 18, 2023
Depends on #82331 |
Treat SIMD as float vars.
BruceForstall
force-pushed
the
ChangeFPHoistProfitability
branch
from
February 19, 2023 19:33
fedba43
to
7d5ef94
Compare
(Modest) diffs show better hoisting: both hoisting int-reg expressions in loops with lots of SIMD, as well as SIMD expressions in loops with lots of int-regs. |
@AndyAyersMS PTAL |
Odd, there are asserts in JitStressRegs=8:
|
Cc. @kunalspathak looks related to the new divrem support |
Filed #82397 for the assert so we can reference that issue on merge with CI failures |
AndyAyersMS
approved these changes
Feb 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat SIMD as float vars.
Fixes #82351